saving icon files - preserving the color

Question

5.00/5 (1 vote)

See more:

I have copied the following code from stack-overflow for generating .ico file from HICON instance. This code works fine except that generated .ico file is blank and white even though original image being pointed by HICON has colors.

C++

#include "stdafx.h" 
#include "windows.h"
#include "olectl.h"
#pragma comment(lib, "oleaut32.lib") 
 
HRESULT SaveIcon(HICON hIcon, const wchar_t* path) { 
    // Create the IPicture intrface 
    PICTDESC desc = { sizeof(PICTDESC) }; 
    desc.picType = PICTYPE_ICON; 
    desc.icon.hicon = hIcon; 
    IPicture* pPicture = 0; 
    HRESULT hr = OleCreatePictureIndirect(&desc, IID_IPicture, FALSE,(void**)&pPicture);
    if (FAILED(hr)) return hr;
 
    // Create a stream and save the image 
    IStream* pStream = 0; 
    CreateStreamOnHGlobal(0, TRUE, &pStream); 
    LONG cbSize = 0; 
    hr = pPicture->SaveAsFile(pStream, TRUE, &cbSize); 
 
    // Write the stream content to the file 
    if (!FAILED(hr)) { 
        HGLOBAL hBuf = 0; 
        GetHGlobalFromStream(pStream, &hBuf); 
        void* buffer = GlobalLock(hBuf); 
        HANDLE hFile = CreateFile(path, GENERIC_WRITE, 0, 0, CREATE_ALWAYS, 0, 0); 
        if (!hFile) hr = HRESULT_FROM_WIN32(GetLastError()); 
        else { 
            DWORD written = 0; 
            WriteFile(hFile, buffer, cbSize, &written, 0); 
            CloseHandle(hFile); 
        } 
        GlobalUnlock(buffer); 
    } 
    // Cleanup 
    pStream->Release(); 
    pPicture->Release(); 
    return hr; 
 }

What can be problem with this code?

Posted 22-Feb-11 0:59am

Rajesh G Manwani from Mumbai

Updated 22-Feb-11 1:03am

Nuri Ismail

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Olivier Levrey · Answer 1 · 2011-02-22T01:33:00

I found this on code project:
http://www.codeproject.com/Messages/2287455/HICON-ico.aspx[^]

PICTDESC pictDesc;
pictDesc.cbSizeofstruct = sizeof(PICTDESC);
pictDesc.icon.hicon = hICon;
pictDesc.picType = PICTYPE_ICON;
IPicture *pPicture = NULL;
IStorage *pStg = NULL;
IStream *pStream = NULL;
LONG lSize = 0;
HRESULT hr = OleCreatePictureIndirect(&pictDesc,IID_IPicture,TRUE,(void**)&pPicture);
hr = StgCreateDocfile(L"c:\\My.ico",STGM_CREATE|STGM_SHARE_EXCLUSIVE|STGM_READWRITE,0,&pStg);
hr = pStg->CreateStream(L"icoStream",STGM_CREATE |
STGM_WRITE |
STGM_DIRECT |
STGM_SHARE_EXCLUSIVE ,0,0,&pStream);
hr = pPicture->SaveAsFile(pStream,TRUE,&lSize);

But I didn't try it...

mbue · Answer 2 · 2011-02-22T12:25:00

try this one:

ICONINFO		ii;
if(GetIconInfo(hicon,&ii))
{
  __IcoSave24(store,ii.hbmMask,ii.hbmColor);
  if(ii.hbmColor) DeleteObject(ii.hbmColor);
  if(ii.hbmMask ) DeleteObject(ii.hbmMask );
}


static void __IcoSave24(vStore& store,HBITMAP hbmMask,HBITMAP hbmColor)
{
  BITMAP  bmiMask;
  BITMAP  bmiColor;
  if(
      GetObject(hbmColor,sizeof(bmiColor),&bmiColor) &&
      GetObject(hbmMask,sizeof(bmiMask),&bmiMask) &&
      (bmiColor.bmWidth==bmiMask.bmWidth) &&
      (bmiColor.bmHeight==bmiMask.bmHeight)
    )
  {
    ICONDIR            icodir;
    ICONDIRENTRY      icoent;
    BITMAPINFOHEADER  icobmi = {0};
    tArr<char>        bits;
    unsigned int      size;

    icodir.idReserved = 0;
    icodir.idType     = 1;
    icodir.idCount    = 1;

    icoent.bWidth        = (unsigned char)bmiColor.bmWidth;
    icoent.bHeight       = (unsigned char)bmiColor.bmHeight;
    icoent.bColorCount   = 8<=bmiColor.bmBitsPixel?0:1<<bmiColor.bmBitsPixel;
    icoent.bReserved     = 0;
    icoent.wPlanes       = bmiColor.bmPlanes;
    icoent.wBitCount     = bmiColor.bmBitsPixel;
    icoent.dwBytesInRes  = sizeof(BITMAPINFOHEADER) + (__bmp_bpl(bmiColor.bmBitsPixel,bmiColor.bmWidth)*bmiColor.bmHeight) + (__bmp_bpl(bmiMask.bmBitsPixel,bmiMask.bmWidth)*bmiMask.bmHeight);
    icoent.dwImageOffset = sizeof(icodir) + sizeof(icoent);

    store.Write(&icodir,sizeof(icodir));
    store.Write(&icoent,sizeof(icoent));

    if(0>bmiMask.bmHeight) Beep(3000,1000);

    icobmi.biSize      = sizeof(icobmi);
    icobmi.biWidth     = bmiColor.bmWidth;
    icobmi.biHeight    = bmiColor.bmHeight + bmiMask.bmHeight;
    icobmi.biPlanes    = 1;
    icobmi.biBitCount  = bmiColor.bmBitsPixel;
    icobmi.biSizeImage = __bmp_bpl(bmiColor.bmBitsPixel,bmiColor.bmWidth)*bmiColor.bmHeight;

    // icoent.dwImageOffset
    store.Write(&icobmi,sizeof(icobmi));

    bits.resize(icobmi.biSizeImage);
    size = GetBitmapBits(hbmColor,bits.count,bits.array);
    store.Write(bits.array,size);
    size = GetBitmapBits(hbmMask,bits.count,bits.array);
    store.Write(bits.array,size);
  }
}

Good luck.

Rajesh G Manwani from Mumbai · Answer 3 · 2011-02-22T21:36:00

Solution 3

I am unable to use this code as definition of some of user datatypes such as vstore, ICONDIR, ICONDIRENTRY is not submitted.

Posted 22-Feb-11 21:36pm

Rajesh G Manwani from Mumbai

Comments

mbue 23-Feb-11 12:52pm

i cant do your work - you should be able to substitute a simple in/out class.
btw: internet has a search function :mad:


#pragma pack(push)
#pragma pack(2)
typedef struct
{
    BYTE        bWidth;          // Width, in pixels, of the image
    BYTE        bHeight;         // Height, in pixels, of the image
    BYTE        bColorCount;     // Number of colors in image (0 if >=8bpp)
    BYTE        bReserved;       // Reserved ( must be 0)
    WORD        wPlanes;         // Color Planes
    WORD        wBitCount;       // Bits per pixel
    DWORD       dwBytesInRes;    // How many bytes in this resource?
    DWORD       dwImageOffset;   // Where in the file is this image?
 
} ICONDIRENTRY, *LPICONDIRENTRY;

typedef struct
{
    WORD           idReserved;   // Reserved (must be 0)
    WORD           idType;       // Resource Type (1 for icons)
    WORD           idCount;      // How many images?
 
    // ICONDIRENTRY   idEntries[1]; // An entry for each image (idCount of 'em)
} ICONDIR;

typedef struct
{
   BITMAPINFOHEADER   icHeader;      // DIB header
   // RGBQUAD						icColors[1];   // Color table
   // BYTE								icXOR[1];      // DIB bits for XOR mask
   // BYTE								icAND[1];      // DIB bits for AND mask

} ICONIMAGE;

#pragma pack(pop)

saving icon files - preserving the color

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0