I want to get the index of largest number in array but I keep getting index zero !!!!!!

Question

0.00/5 (No votes)

See more:

I'm doing a function that returns the index of the largest number in the array ;it's an easy function but I don't know why I'm getting stuck with code.whatever numbers I enter it returns an index number 0 although the largest number maybe in index number 6 or 7 for example.this is my code:

C#

int MAX_INT(int arr[],int s)
{
  int Max,temp;
  int i=0;
  temp=i;
  Max=arr[i];
  while(i<s)
  {
      if(Max>arr[i+1])
      {
          Max=arr[0];
          temp=0;
      }


      else{
          Max=arr[i+1];
          temp=i;
      }
     i++;
  }
  return temp;
}
int main()
{
  int arr[SIZE];
	for(int i=0;i<SIZE;i++)
	
		cin>>arr[i];
	
	cout<<MAX_INT(arr,SIZE);
}

Thank you
:)

Posted 22-Feb-11 1:47am

goodtogo

Add a Solution

4 solutions

Solution 1

What is the purpose of the if/else ? A simple if block would work fine:

if (Max > arr[i])
{
   Max=arr[i];
   temp=i;
}

Posted 22-Feb-11 1:54am

Cedric Moonen

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

SenAPI · Accepted Answer · 2011-02-22T02:31:00

Solution 4

Change your if statement ;

int MAX_INT(int arr[],int s)
{
    int Max,temp;
    int i=0;
    temp=i;
    Max=arr[i];
    while(i<s)>
    {
        if (Max < arr[i])
        {
            Max=arr[i];
            temp=i;
        }
        i++;
    }
    return temp;
}

Posted 22-Feb-11 2:31am

SenAPI

Alain Rist · Accepted Answer · 2011-02-22T03:29:00

Solution 5

Quicker, safer, simpler:

C++

#include <algorithm>
int MAX_INT(int arr[],int s)
{
    return std::max_element(arr, arr + s) - arr;
}

cheers,
AR
Edited to return index.

Posted 22-Feb-11 3:29am

Alain Rist

Updated 22-Feb-11 3:49am

v2

Comments

Olivier Levrey 22-Feb-11 9:43am

This returns the largest element in the array. Not its index.

Alain Rist 22-Feb-11 9:51am

Right, corrected :)

Olivier Levrey · Accepted Answer · 2011-02-22T02:03:00

Ba careful with your index:

int MAX_INT(int arr[],int s)
{
  int i=0;
  Max=arr[i];
  while(i<s)
  {
      //what will happen if i equals s - 1 ???
      if(Max>arr[i+1])
      {
          //...
      }
      i++;
   }
}

I suggest this:

int MAX_INT(int arr[], int s)
{
   if (s <= 0)
      return -1;
   int maxIndex = 0;
   int maxValue = arr[0];
   for (int i = 1; i < s; i++)
   {
      if (arr[i] > maxValue)
      {
          maxValue = arr[i];
          maxIndex = i;
      }
   }
   return maxIndex;
}

I want to get the index of largest number in array but I keep getting index zero !!!!!!

4 solutions

Solution 4

Solution 5

Solution 3

Solution 1

Add your solution here

Preview 0

I want to get the index of largest number in array but I keep getting index zero !!!!!!

4 solutions

Solution 4

Solution 5

Solution 3

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us