How to give Try ,catch blocks ?

Question

1.20/5 (2 votes)

See more:

C#

public int? FarmInfraDetailsUpdate(FarmRecordPL FormrecordPL)
        {

            SqlParameter[] arParams = new SqlParameter[7];

            arParams[0] = new SqlParameter("@shedid", typeof(int));
            arParams[0].Value = FormrecordPL.shedid;


            arParams[1] = new SqlParameter("@shedno", typeof(int));
            arParams[1].Value = FormrecordPL.shedno;


            arParams[2] = new SqlParameter("@length", typeof(int));
            arParams[2].Value = FormrecordPL.length;

            arParams[3] = new SqlParameter("@width", typeof(int));
            arParams[3].Value = FormrecordPL.width;

            arParams[4] = new SqlParameter("@totalarea", typeof(int));
            arParams[4].Value = FormrecordPL.totalarea;

            arParams[5] = new SqlParameter("@capacity", typeof(int));
            arParams[5].Value = FormrecordPL.capacity;

            arParams[6] = new SqlParameter("@username", typeof(string));
            arParams[6].Value = FormrecordPL.capacity;

            return Convert.ToInt16(SqlHelper.ExecuteScalar(connection.ConnectionString, CommandType.StoredProcedure, "k_UpdateFarmRecordInfraDetail", arParams));

        }

Posted 24-Jan-14 17:28pm

Siva Hyderabad

Add a Solution

Comments

Ron Beyer 24-Jan-14 23:30pm

Ok, a vague title and a code dump do not a question make. Please tell us what you need or what you are trying to accomplish.

Mitchell J. 24-Jan-14 23:31pm

Wow, second to second comments!

Ron Beyer 24-Jan-14 23:32pm

Well if anything we are consistent!

Mitchell J. 24-Jan-14 23:42pm

:-)

Mitchell J. 24-Jan-14 23:30pm

This question is not very clear. What are you trying to do?

Siva Hyderabad 24-Jan-14 23:34pm

public int? FarmInfraDetailsUpdate(FarmRecordPL FormrecordPL)
{
Try
{
//Code..
}
Catch(Exception ex)
{
}
}
It shows an error like "Not all code paths return value..because i am taken Int datetyep

Mitchell J. 24-Jan-14 23:38pm

It's giving you that error because you are not returning anything in the catch block.

Siva Hyderabad 24-Jan-14 23:39pm

yes..how to give return value..

Mitchell J. 24-Jan-14 23:42pm

I've posted a solution.

2 solutions

Solution 2

I assume you used a nullable int return Type here so you could detect an error in updating the record.

So, why not return a null in the catch-block, so: when your method returns, you can test if the returned value is null, and handle the fact that the record was not updated ?

Posted 24-Jan-14 17:52pm

BillWoodruff

Comments

Mitchell J. 24-Jan-14 23:53pm

Good call.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mitchell J. · Accepted Answer · 2014-01-24T17:41:00

You need to return something when an error happens, to be consistent with the fact that this must return an int.

C#

public int? FarmInfraDetailsUpdate(FarmRecordPL FormrecordPL)
{
    try
    {
        //Your code...
        return Convert.ToInt16(SqlHelper.ExecuteScalar(connection.ConnectionString, CommandType.StoredProcedure, "k_UpdateFarmRecordInfraDetail", arParams));

    }
    catch
    {
        //Now you need to return something else
        return 0; //Just a suggestion!
    }
}