optimising SQL query

Question

0.00/5 (No votes)

See more:

Dear all,

I'm using the following query (as stored procedure) in a news portal, the problem is this query is taking very very high execution time and it's considered as expensive query, i need help optimizing it.

SQL

Select Top(@Count) site_News.NewsID, site_News.Title, count(site_Replies.ReplyID) as 'replies-count'
From site_News Inner Join site_Replies
on site_News.NewsID = site_Replies.NewsID
Inner Join site_Categories on site_News.CategoryID = site_Categories.CategoryID
Where site_news.AddDate > DATEADD (day , -7 , GETDATE() ) And site_Replies.Accept = 1 And site_Replies.Active = 1
And site_Categories.LanguageID = @LanguageID
group by site_News.NewsID, site_News.Title
order by 'replies-count' desc

The query aims to get the news with highest number of active replies, the news must be added in the past 7 days.
Thanks in advance.

Posted 29-Dec-13 0:15am

WaleedMuh

Updated 29-Dec-13 2:12am

v2

Add a Solution

2 solutions

Solution 2

This is quite often asked question, but the answer is: No one can do it for you.

There are several things to do to improve query performance[^].

Posted 29-Dec-13 1:46am

Maciej Los

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

S. M. Ahasan Habib · Accepted Answer · 2013-12-29T01:42:00

Solution 1

You just make sure following columns are indexed. If any one them is not indexed then pls create indexes for those columns and re execute your query in your database.
1.site_News.NewsID
2.site_Replies.NewsID
3.site_News.CategoryID
4.site_Categories.CategoryID
5.site_news.AddDate
6.site_Categories.LanguageID
7.site_Replies.Accept
8.site_Replies.Active

Posted 29-Dec-13 1:42am

S. M. Ahasan Habib

Comments

WaleedMuh 29-Dec-13 9:33am

I added index to these columns, as i didn't have index on most of them, and it worked like a charm.
SQL server CPU usage dropped to ~ 3% from 90% !
Thanks!

S. M. Ahasan Habib 29-Dec-13 16:30pm

you are most welcome