error in sql procedure

Question

0.00/5 (No votes)

See more:

Hi

i would like to know how can i solve this error

Error converting data type nvarchar to datetime

when i run this procedure

SQL

alter proc Ledger

@Account_Serial int ,
@DateFrom datetime,
@DateTo datetime
as


SELECT     GLD_JOURNAL_ENTRY_DETAILES.ACCOUNT_SERILA_NO, SUM(GLD_JOURNAL_ENTRY_DETAILES.DEBIT_VALUE) AS DEBIT_VALUE, 
                      SUM(GLD_JOURNAL_ENTRY_DETAILES.CREDIT_VALUE) AS CREDIT_VALUE
FROM         GLD_JOURNAL_ENTRY_DETAILES INNER JOIN
                      GLD_JOURNAL_ENTRIES ON GLD_JOURNAL_ENTRY_DETAILES.JOURNAL_ENTRY_NO = GLD_JOURNAL_ENTRIES.Journal_ENTRY_NO
WHERE     (GLD_JOURNAL_ENTRIES.TRANSFER_DATE --BETWEEN @DateFrom AND @DateTo
between convert(datetime ,CONVERT(nvarchar(20),@DateFrom) ,102)
 and convert(datetime,CONVERT(nvarchar(20),@DateTo) ,105)
)

 
 
GROUP BY GLD_JOURNAL_ENTRY_DETAILES.ACCOUNT_SERILA_NO
HAVING      (GLD_JOURNAL_ENTRY_DETAILES.ACCOUNT_SERILA_NO = @Account_Serial)

any idea

Posted 10-Dec-13 2:44am

Darsh_Basha

Add a Solution

Comments

Ganesh Raja 10-Dec-13 8:50am

Already the @DateFrom and @DateTo in datetime format then why u r trying to convert again?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2013-12-10T02:57:00

Solution 1

Why are you passing DateTime values (sensible) and then converting them to the Sql default format (yyyy-MM-dd) and then trying to convert them back to a datetime as if they were in ANSI format (yy.MM.dd)?
Just use them directly as in your comments, or use CAST to remove the time portion:

SQL

WHERE GLD_JOURNAL_ENTRIES.TRANSFER_DATE BETWEEN CAST(@DateFrom AS DATE) AND CAST(@DateTo AS DATE)

Posted 10-Dec-13 2:57am

OriginalGriff

Comments

Darsh_Basha 10-Dec-13 9:22am

Hi @OriginalGriff

i tried ur answer

USE [CS_ATC]
GO

DECLARE @return_value int

EXEC @return_value = [dbo].[Ledger]
@Account_Serial = 4,
@DateFrom = N'26/1/2013',
@DateTo = N'1/1/2014'

SELECT 'Return Value' = @return_value

GO

and return this error

Error converting data type nvarchar to datetime.

OriginalGriff 10-Dec-13 9:27am

Where did I suggest that?
I can't see anything like that suggested...