stopping a loop from repeating

Question

0.00/5 (No votes)

See more:

<hello everyone i have application that calls a function at a specific time.The problem is it repeats the same function and it does not get out of the loop eg if its calls a function at 10:00 am it will keep on calling the same function until time changes to 10:01..

here is my code below

VB

Dim dt As DateTime = DateTime.Now


      Dim strHours As String
      Dim strMinutes As String

      ' Dim inTDay
      strTime = dt.ToString()
      ' inTDay = dt.DayOfWeek
      strHours = dt.Hour.ToString()
      strMinutes = dt.Minute.ToString()
      strTime = strHours & ":" & strMinutes

If dt.DayOfWeek <> DayOfWeek.Saturday Then
          If dt.DayOfWeek <> DayOfWeek.Sunday Then




                  For i As Integer = 0 To ListView1.Items.Count - 1
                  subone = ListView1.Items(i).SubItems(2).Text

                  subone = Microsoft.VisualBasic.Right(subone, 11)
                  subone = Microsoft.VisualBasic.Left(subone, 5)
                  subtwo = ListView1.Items(i).SubItems(3).Text

                  If strTime = subone And subtwo = "Y" Then
                      strFunction = ListView1.Items(i).SubItems(1).Text




                      Call Select_Jobs()

                      If strTime = subone Then
                          Exit For
                      End If
                      'H
                      '
                      '





                  End If



              Next

Posted 17-Sep-13 23:11pm

Member 10250527

Add a Solution

Comments

Pheonyx 18-Sep-13 6:02am

What sort of values are you getting in "subone" ?
What does "Select_Jobs()" do ?
Does the program ever get into the if statement "strTime = subone And subtwo = "Y" "?

Member 10250527 18-Sep-13 6:31am

The subone has the time and the select_job() selects jobname from the list view then it passes the values to the subroutines...yes it gets into the if statment "strTime = subone And subtwo = "Y".But the problem is when it gets to strTime it will call the same method until time changes.

[no name] 18-Sep-13 6:23am

Okay.... so what is the question?

Member 10250527 18-Sep-13 6:38am

I have application that calls specific subroutines at the certain time on the listview...(jobid.jobName.Time.Status)so my loop keeps on repeating same jobname at the same time wen it runs.

[no name] 18-Sep-13 7:33am

Yes I see that that very odd functionality. So it's doing exactly what you told it to do. Did you have some sort of a question about it?

Member 10250527 18-Sep-13 8:31am

Yes,i want it not to call the same method until the time changes,when the loop comes back to the called method it should not be able to call the same method if the time has not changed,it should call the next method.

Manoj K Bhoir 18-Sep-13 9:39am

Why you are not considering Seconds and milliseconds i.e. (HH:MM:ss tt) instead of HH:MM.
I think you should use 10:00:00 00 instead of 10:00. It will Solve your Problem. :)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

pdoxtader · Answer 1 · 2013-09-18T02:53:00

I would store the last time your function was called in a global variable, and check it before attempting to run the code in this function.

For instance, in a module somewhere:

VB

Public lastRun as String

Then your code would look something like:

VB

Dim dt As DateTime = DateTime.Now
 

Dim strHours As String
Dim strMinutes As String
 
' Dim inTDay
strTime = dt.ToString()
' inTDay = dt.DayOfWeek
strHours = dt.Hour.ToString()
strMinutes = dt.Minute.ToString()
strTime = strHours & ":" & strMinutes

If lastRun <> strTime Then
   lastRun = strTime
   ' The rest of your function's code here.
Else
   ' You should do a short Thread.Sleep() here, or if this is on the UI thread an
   ' Application.DoEvents(). If you don't, then while your app is checking to see if it 
   ' should run your function (for the minute), one of your CPUs will be pegged, or
   ' if this is in the UI thread, then the UI will be unresponsive.
End If

This way your code will only run once when the target time is reached.

- Pete