Some problem in function that return int

Question

1.00/5 (1 vote)

See more:

hiii all,

I made a function that return a count of table in (int) and use that returned int to be displayed in a textbox.

I made that code but it always returns (-1). Anyone can tell me where the error is?

C#

public Int64 bulidcount()
    {
        Int64 iQryValue;
        SqlConnection conn = new SqlConnection(connstr);
        SqlCommand cmd_save = new SqlCommand();
        cmd_save.Connection = conn;
        cmd_save.CommandType = CommandType.StoredProcedure;
        cmd_save.CommandText = "usp_test";
        try
        {
             conn.Open();
            iQryValue = cmd_save.ExecuteNonQuery();
            return iQryValue;
        }
        catch (Exception ex)
        {
            if (conn.State == ConnectionState.Open)
            {
                conn.Close();
            }
            return 1;
        }  
 
    }

C#

Int64 iResult = bulidcount();
 txt_MobileCount.Text = iResult.ToString();

Posted 22-Jan-11 21:07pm

moon2011

Updated 23-Jan-11 18:12pm

Sergey Alexandrovich Kryukov

v4

Add a Solution

Comments

Sergey Alexandrovich Kryukov 24-Jan-11 0:12am

Fixed typo in the title. Watch this: http://www.youtube.com/watch?v=u9_kahA_wQo
--SA

5 solutions

Solution 2

It may be related to your stored procedure, which we can't see because you haven't given us the code.

But, it is worth noting that MSDN[^] on ExecuteNonQuery says:

Although the ExecuteNonQuery does not return any rows, any output parameters or return values mapped to parameters are populated with data.
For UPDATE, INSERT, and DELETE statements, the return value is the number of rows affected by the command. For all other types of statements, the return value is -1. If a rollback occurs, the return value is also -1.

It may be worth your reading up on returning values from stored procedures. There is a good explanation here.[^]

Posted 22-Jan-11 21:17pm

OriginalGriff

Comments

moon2011 23-Jan-11 3:33am

Thanks OriginalGriff for your help

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-01-23T15:10:00

Solution 5

Disclaimer: this is not intended to answer a question.

Instead, this is a warning about a much more serious mistake.

Why the code returns 1 when exception is thrown? Does 1 indicate an error? Does it mean that when iQryValue == 1 it should be considers as an error?!

More importantly, this is a very bad and unsafe practice to block an exception from propagation as shown in the code sample (except pretty rare cases when there is no other options).
In the code, the line "return 1;" should be replaced with "throw;". It will re-throw the same exception.

Posted 23-Jan-11 15:10pm

Sergey Alexandrovich Kryukov

Updated 23-Jan-11 15:11pm

v2

Comments

fjdiewornncalwe 23-Jan-11 22:36pm

100% agreement from me. +5.

moon2011 26-Jan-11 5:35am

i didn't mean that returning one refers to an exception , but it was reference for me only and i know that it shouldn't be like that.
thanks alot for your advice.

Sergey Alexandrovich Kryukov 26-Jan-11 12:46pm

You're very welcome. No matter what you meant to do, do yourself a favor: always re-throw or throw, don't block propagation of exception. You also never need to return any error condition from any function: exceptions made this technique gravely obsolete.
Good luck.
--SA

Espen Harlinn 6-Feb-11 15:01pm

Good advice, a 5

**R. Giskard Reventlov** · Accepted Answer · 2011-01-22T21:15:00

Solution 1

Try:

cmd_save.ExecuteScalar();

ExecuteNonQuery only returns the number of rows affected (after carrying out whatever your stored procedure does), ExecuteScalar will return the result of your stored procedure (whatever that might be).

Posted 22-Jan-11 21:15pm

R. Giskard Reventlov

v2

Comments

moon2011 23-Jan-11 3:34am

Thanks digital man for your help

Sandeep Mewara · Accepted Answer · 2011-01-22T21:20:00

Solution 3

I guess, your logical error lies here:
cmd_save.ExecuteNonQuery(); & StoredProcedure called.

Adding to that, probably you must have enabled 'no count' in SP. Remove it.

ExecuteNonQuery: Executes insert/update/delete & returns number of rows affected. Details here[^].

Just to add on, a similar discussion here[^].

Posted 22-Jan-11 21:20pm

Sandeep Mewara

Comments

moon2011 23-Jan-11 3:33am

Thanks Sandeep Mewara for your help

Michael Waguih · Accepted Answer · 2011-01-22T21:23:00

Solution 4

Hi Monamoona,

Change :

C++

iQryValue = cmd_save.ExecuteNonQuery();

with :

C++

iQryValue = cmd_save.ExecuteScalar();

I hope this help ,
Good luck :)

Posted 22-Jan-11 21:23pm

Michael Waguih

Comments

moon2011 23-Jan-11 3:32am

Thanksss Michael Waguih for your help

Michael Waguih 23-Jan-11 3:37am

You are welcome :)