guid problem in update

Question

1.00/5 (1 vote)

See more:

Hi i have a guid abcde and i have id in table guid i want to make an update but doesn works.

string cmd1 = "UPDATE Publisher SET checkid='"+ CheckBoxList1.SelectedValue.ToString() + "' WHERE idi=" + abcde + "";

abcde value is 1996c33b-786c-4acf-87c1-14c9c9fbc879

The error is: Incorrect syntax near 'c33b'.

Please help.

Posted 28-Nov-10 17:45pm

Prevas

Updated 28-Nov-10 17:58pm

Abhinav S

v3

Add a Solution

3 solutions

Solution 2

First, you should never use unvalidated input from asp.net for a database query. Second, don't use string concatenation. You should use parameterized queries.

Posted 28-Nov-10 18:00pm

Not Active

Comments

Prevas 29-Nov-10 0:22am

I am just testing it first. if it works then i will put parameters

[no name] 29-Nov-10 7:07am

Wrong answer! Do it right the first time.

Prevas 29-Nov-10 8:47am

ok

Solution 3

WHERE idi=" + abcde + "";

Make sure abcde is of type GUID.

Posted 28-Nov-10 18:09pm

Abhinav S

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

@nuraGGupta@ · Accepted Answer · 2010-11-28T17:56:00

Solution 1

Hi Prevas,
Why dont you use GUID as

C#

GUID.ToString().Substring(0,7)

or you can also use

C#

GUID.ToString().Replcae("-","")

;

This way you will not get any "-" during queries and hence can avoid such type of errors.

Anurag

Posted 28-Nov-10 17:56pm

@nuraGGupta@

Comments

Prevas 29-Nov-10 0:21am

the idi in database is 1996c33b-786c-4acf-87c1-14c9c9fbc879 when i make with GUID.ToString().Replcae("-","")
it gives me this error:Incorrect syntax near 'c33b786c4acf87c114c9c9fbc879'.
:(

@nuraGGupta@ 29-Nov-10 0:29am

check your "where" syntax, it is wrong.
It should be:

WHERE idi="+"'" + abcde + "'"+"";

Please check this way and inform if still the problem persists.
By the way, who is downvoting me here? [;P]

Prevas 29-Nov-10 0:44am

there is no error but its not updating :(

dont worry my friend i will make it work somehow

@nuraGGupta@ 29-Nov-10 1:16am

ok, this seems to be another problem. Do tell me what was the issue, when you correct it. I feel like checklistbox rebinding during the time of postback may be a cause.