if condition is not checked

Question

4.00/5 (1 vote)

See more:

Hello friends,
this is my code

C#

private void button1_Click(object sender, EventArgs e)
       {
           if (textBox1.Text=="")
           {
               MessageBox.Show("please enter the school Id");
           }
           else
           {
              // int m = Convert.ToInt32(textBox1.Text);
               sb.SCHOOLID = int.Parse(textBox1.Text);
           }
           if (textBox2.Text == "")
           {
               MessageBox.Show("please ente the school name");
           }
           else
           {
               sb.SCHOOLNAME = textBox2.Text.ToString();
           }
           sb.CREATEDDATEANDTIME = DateTime.Now;

when executing this code if condition is chcking when i left the textbox as an empty.What could be the problem?

Posted 24-Jul-12 21:59pm

baskaran chellasamy

Add a Solution

Comments

bbirajdar 25-Jul-12 5:09am

Both the solutions are valid..Why did you downvote them ?

3 solutions

Solution 3

Use the following code, this will help you:

C#

private void button1_Click(object sender, EventArgs e)
{
           if (textBox1.Text.Trim() == String.Empty)
           {
               MessageBox.Show("please enter the school Id");
           }
           else
           {
              // int m = Convert.ToInt32(textBox1.Text);
               sb.SCHOOLID = int.Parse(textBox1.Text);
           }
           if (textBox2.Text.Trim() == String.Empty)
           {
               MessageBox.Show("please ente the school name");
           }
           else
           {
               sb.SCHOOLNAME = textBox2.Text.ToString();
           }
           sb.CREATEDDATEANDTIME = DateTime.Now;
}

Posted 24-Jul-12 23:13pm

Muhammad Shahid Farooq

Updated 24-Jul-12 23:15pm

v2

Comments

Prasad_Kulkarni 25-Jul-12 5:16am

Good suggestion to use Trim().
My 5!

BillW33 25-Jul-12 10:16am

Trim is a good idea, +5.

Solution 2

C#

private void button1_Click(object sender, EventArgs e)
        {
            if (string.IsNullOrEmpty(textBox1.Text.Trim()))
            {
                MessageBox.Show("please enter the school Id");
                return;
            }
            else if (string.IsNullOrEmpty(textBox2.Text.Trim()))
            {
                MessageBox.Show("please ente the school name");
                return;
            }
            else
            {
                // int m = Convert.ToInt32(textBox1.Text);
                sb.SCHOOLID =  Convert.ToInt32(textBox1.Text);
                sb.SCHOOLNAME = textBox2.Text.ToString();
                sb.CREATEDDATEANDTIME = DateTime.Now;
            }
        }

Posted 24-Jul-12 22:34pm

Raghunatha_Reddy_S

v2

Comments

bbirajdar 25-Jul-12 5:10am

countered ..+5

Raghunatha_Reddy_S 26-Jul-12 1:16am

:-)

Prasad_Kulkarni 25-Jul-12 5:16am

Good alternative +5

Raghunatha_Reddy_S 26-Jul-12 1:16am

:-)

BillW33 25-Jul-12 12:18pm

Good answer, +5.

Raghunatha_Reddy_S 26-Jul-12 1:16am

:-)

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2012-07-24T22:10:00

Solution 1

Well, if there is nothing in your textbox (not even a space) then if condition will be true and MessageBox will be displayed.

Posted 24-Jul-12 22:10pm

Sandeep Mewara

Comments

baskaran chellasamy 25-Jul-12 4:22am

i leave the textbox as an empty but when i trace the code if condition is executed and it went to else condition.i dont know why.please help me.

Sandeep Mewara 25-Jul-12 5:28am

Use Trim() to confirm that it is empty textbox.

use string.IsNullOrEmpty() method for comparison.

Sandeep Mewara 25-Jul-12 5:29am

Have you asked the real question on why I am not getting message alert, i would have suggested you of using Trim and IsNullOrEmpty methods. Next time, be clear on what are you trying and stuck up with.

bbirajdar 25-Jul-12 5:10am

You need to Trim() the textbox values as shown in solution 2

bbirajdar 25-Jul-12 5:11am

countered ..+5

Prasad_Kulkarni 25-Jul-12 5:15am

Valid +5!

BillW33 25-Jul-12 12:16pm

Decent answer, upvoted :)

if condition is not checked

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0

if condition is not checked

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us