c# adding dynamic button

Question

2.00/5 (2 votes)

See more:

C#

Button[,] btn = new Button[Convert.ToInt32(textBox1.Text), Convert.ToInt32(textBox2.Text)];

           for (int i = 0; i < Convert.ToInt32(textBox1.Text); i++)
           {
               for (int j = 0; j <= Convert.ToInt32(textBox2.Text); j++)
               {
                   btn[i, j] = new Button();
                   this.Controls.Add(btn[i, j]);

                   if (i > 2)
                   {
                       btn[i, j].Left = 100 + btn[i-1, j-1].Left;
                       btn[i, j].Top = 100 + btn[i-1, j-1].Top;
                   }
                   else
                   {
                       btn[i, j].Left = 100;
                       btn[i, j].Top = 100;
                   }


               }

           }

it says index out of Range.
I dont know why!

Posted 10-Jul-12 4:34am

mrmarzban

Add a Solution

Comments

[no name] 10-Jul-12 10:38am

Because you are iterating over your array too many times.

Sergey Alexandrovich Kryukov 10-Jul-12 15:49pm

What, if you didn't see the problem immediately, never used the debugger? Try to solve the simple problems on your own.
--SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Shahin Khorshidnia · Accepted Answer · 2012-07-10T04:51:00

Solution 1

Correct the loop for j:

C#

//for (int j = 0; j <= Convert.ToInt32(textBox2.Text); j++)
for (int j = 0; j < Convert.ToInt32(textBox2.Text); j++)

And this causes error too:

C#

if (i > 2)
{
    btn[i, j].Left = 100 + btn[i-1, j-1].Left;
    btn[i, j].Top = 100 + btn[i-1, j-1].Top;
}

Use this one instead:

C#

//if (i > 2)
//{
//    btn[i, j].Left = 100 + btn[i-1, j-1].Left;
//    btn[i, j].Top = 100 + btn[i-1, j-1].Top;
//}

btn[i, j].Left = (i > 0)? 100 + btn[i - 1, j].Left : 100;

btn[i, j].Top = (j > 0)? 100 + btn[i, j - 1].Top : 100;

Posted 10-Jul-12 4:51am

Shahin Khorshidnia

Updated 10-Jul-12 5:06am

v5

Comments

Sander Rossel 10-Jul-12 11:09am

Simple, yet effective. My 5.

Shahin Khorshidnia 10-Jul-12 11:10am

Thank you very much Naerling :)

Sergey Alexandrovich Kryukov 10-Jul-12 15:49pm

Sure, a 5.
--SA

Shahin Khorshidnia 10-Jul-12 23:49pm

Thank you a lot :)