store Procedure in sql server

Question

0.00/5 (No votes)

See more:

i have a store procedure like....

SQL

create Procedure [dbo].[stp_UpdateDoctorAvailability] @Day nvarchar(20),@TimeString nvarchar(500), @DoctorId int as
begin
Update tblDoctorsAvailability set @Day=@Timestring where DoctorsId = @DoctorId
end

here "@day" is user Defined Column name its executing but its not updating the table values its showing previous values only please could anybody help me in this please.......

thank you in Advance

Posted 18-Jun-12 20:58pm

chetan B Y

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

walterhevedeich · Answer 1 · 2012-06-18T21:09:00

Solution 1

You can't do that directly. You need to implement dynamic SQL to do it. See the following code.

SQL

DECLARE @query NVARCHAR(1000)
set @query = 'UPDATE tblDoctorsAvailability SET ' + @Day + '=' + @Timestring + 'WHERE DoctorsId = ' + CAST(@DoctorId AS NVARCHAR(20));
EXEC(@query)

[Edit]
You need to use CAST or CONVERT[^] to convert an integer type to character type before concatenating it. I have update the query using CAST
[/Edit]

Posted 18-Jun-12 21:09pm

walterhevedeich

Updated 18-Jun-12 21:50pm

v3

Comments

chetan B Y 19-Jun-12 3:36am

its giving an Error like

Msg 245, Level 16, State 1, Procedure stp_UpdateDoctorAvailability, Line 4
Conversion failed when converting the nvarchar value 'UPDATE tblDoctorsAvailability SET Monday=chetan WHERE DoctorsId = ' to data type int.

walterhevedeich 19-Jun-12 3:51am

I have updated my answer. Take a look.

Prosan · Answer 2 · 2012-06-18T21:55:00

you can doit by dynamic query.
and convert @doctorid in varchar using convert command.

SQL

DECLARE @qry VARCHAR(max)
set @qry ='UPDATE tblDoctorsAvailability SET ' + @Day + '=' + @Timestring + 'WHERE DoctorsId = ' + convert(varchar(10),@DoctorId) +'
print (@qry)
EXEC(@qry)

in place of convert you can also use cast command as

SQL

DoctorsId = ' + cast(@DoctorId as varchar(10)) +'

manvith SQL Developer · Answer 3 · 2012-06-19T18:59:00

Solution 3

SQL

create Procedure [dbo].[stp_UpdateDoctorAvailability]
 @Day nvarchar(20),
 @TimeString nvarchar(500),
 @DoctorId int
 as
begin
Update tblDoctorsAvailability set Day=@day
    where DoctorsId = @DoctorId
end

Posted 19-Jun-12 18:59pm

manvith SQL Developer

Updated 19-Jun-12 19:05pm

v2