to insert value in ms sql 2005

Question

0.00/5 (No votes)

See more:

I have used this code to insert value in the database , but it is not working....
can any one help me!!!!!

C#

private void savbtn_Click(object sender, EventArgs e)
        {
            try
            {
                SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["WindowsFormsApplication1.Properties.Settings.schoolConnectionString"].ConnectionString);
                con.Open();
                SqlCommand com = new SqlCommand();
                com.Connection = con;
                com.CommandText = "insert into Registration values('" + textBox1.Text + "','" + maskedTextBox1.Text + "','" + maskedTextBox2.Text + "','" + textBox2.Text + "','" + textBox3.Text + "','" + textBox4.Text + "','" + textBox5.Text + "','" + textBox6.Text + "','" + textBox7.Text + "','" + maskedTextBox3.Text + "','" + textBox8.Text + "','" + textBox9.Text + "'," + textBox10.Text + ")";
                com.ExecuteNonQuery();
                MessageBox.Show("Record is saved");
                autoNo();
                maskedTextBox2.Clear();
                textBox2.Clear();
                textBox3.Clear();
                textBox4.Clear();
                textBox5.Clear();
                textBox6.Clear();
                textBox7.Clear();
                maskedTextBox3.Clear();
                textBox8.Clear();
                textBox10.Clear();
            }
            catch
            {
                MessageBox.Show("error:");
            }
        }

Posted 6-Jun-12 0:08am

Member 8517343

Add a Solution

Comments

AmitGajjar 6-Jun-12 6:41am

what error you are getting ? have you debug your code ?

Sandeep Mewara 6-Jun-12 6:46am

Elaborate "not working". Error?

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Oleksandr Kulchytskyi · Answer 1 · 2012-06-06T00:55:00

Hi first of all , it's not safety to insert a value to SQL via text.
It would be better to use SqlParameter class instead, to put values to DB.

C#

try
            {
                SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["WindowsFormsApplication1.Properties.Settings.schoolConnectionString"].ConnectionString);
                con.Open();
                SqlCommand com = new SqlCommand();
                com.Connection = con;
                com.CommandText = "insert into Registration(Name,Id) values(@p1,@p2 ...);
                
var p1=new SqlParameter("@p1", SqlDbType.VarChar);
p1.Value="Hello";
com.Parameters.Add(p1);

var p2=new SqlParameter("@p2", SqlDbType.Int);
p2.Value=78;
com.Parameters.Add(p2);

com.ExecuteNonQuery();
                MessageBox.Show("Record is saved");
                autoNo();
                maskedTextBox2.Clear();
                textBox2.Clear();
                textBox3.Clear();
                textBox4.Clear();
                textBox5.Clear();
                textBox6.Clear();
                textBox7.Clear();
                maskedTextBox3.Clear();
                textBox8.Clear();
                textBox10.Clear();
            }
            catch
            {
                MessageBox.Show("error:");
            }

Sandeep Mewara · Answer 2 · 2012-06-06T01:00:00

Second thought, read about ADO.NET here and it will help you.

Look at these:
MSDN: ADO.NET[^]
MSDN: Accessing Data with ADO.NET[^]

Further, look here for parameterized query and it's usage to avoid SQL Injection (which is highly possible the way you have coded right now!):
MSDN: Configuring Parameters and Parameter Data Types (ADO.NET)[^]
MSDN: DataAdapter Parameters (ADO.NET)[^]
MSDN: SqlCommand.Parameters Property [^]

P N Bhaskar · Answer 3 · 2012-06-06T20:00:00

Solution 3

you r not mentioned ' ' in " + textBox10.Text + " please keep inside ' ' like ' " +textBox10.Text+"'

i think its work

Posted 6-Jun-12 20:00pm

P N Bhaskar

to insert value in ms sql 2005

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0