Error related to HTML helper class voor a button

Question

4.00/5 (1 vote)

See more:

Source Error:
Line 31: <div class="mybutton left"></div>
Line 32: <div class="mybutton middle">
Line 33: @Html.FirstButton("Back", "Marketing", "Finance", new { ID = Model. Finance.ID }, new { @class = "mybutton " }) </div>
Line 34: <div class="mybutton right">
Line 35: </div>

Posted 14-May-12 2:37am

Utrech576

Updated 20-May-12 23:51pm

v6

Add a Solution

Comments

Manfred Rudolf Bihy 14-May-12 8:51am

Added appropriate tags! Please don't just wrap your whole answer in a text tag. Always use the correct tag for the type of code you posted.

Thanks for your cooperation!

Karthik. A 14-May-12 9:31am

Instead of new { ID = Model. Finance.ID } can you try passing in a dictionary<string,object> ? Like new Dictionary<string,object> { {"something", 5 }} ? I guess this should fix your problem.
Edit - added mvc 3 tag.

2 solutions

Solution 1

1) TagBuilder is for building html tags. "styledbuttonprimary" is not a tag in html. Your helper method name has nothing to do with it.
2) Your helper method has 2 parameters, but you try to call it with 5. You build the method, you dont inherit it! So build a proper formal parameter list in the prototype, or dont add what you have allready in the body of the method.
3) You know, that you have added the "text" parameter three times? What for?
4) You can compose from the ID and the css class one single inline class:

C#

@Html.StyledbuttonPrimary("Back", new { ID = Model.Finance.ID, @class = "styledbutton" })

and

C#

public static MvcHtmlString StyledbuttonPrimary(this HtmlHelper Helper, string text, IDictionary<string, object> htmlAttributes)
      {
        var builder = new TagBuilder("button");
        builder.InnerHtml = text;
        builder.MergeAttributes(htmlAttributes);
        return MvcHtmlString.Create(builder.ToString());
      }

5) Are you sure with IDictionary<string,object>? <string,string> would be better, I dont know if automatic casting will work in properly...

Posted 14-May-12 5:26am

Zoltán Zörgő

Updated 14-May-12 5:35am

v7

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Zoltán Zörgő** · Accepted Answer · 2012-05-15T08:21:00

Yes, you see it right. If you want compex html code to be built by your helper, you need to do exactly what you have included at the end of your comment:
you can use tagbuilders that have as InnerHtml the result of another tagbuilder. This is the way.
Here is how you can use your parameters to build the A tag:

C#

var anchorBuilder = new TagBuilder("a");
anchorBuilder.MergeAttribute("href", url.Action(actionName, controllerName, routeValues));
anchorBuilder.MergeAttribute("title", linkText);
anchorBuilder.MergeAttributes(htmlAttributes);

I think you can figure out the rest of the helper.