how reduce time consuming of below query

Question

0.00/5 (No votes)

See more:

Hi,

C#

List<DataRow> list = dtxml.AsEnumerable().Take(r).ToList();
foreach (DataRow dRremove in list)
{
    dtxml.Rows.Remove(dRremove);
    dtxml.AcceptChanges();
}

The above datatable deletion take much more time. How to reduce time consuming.

Posted 4-Jan-12 1:32am

K N R

Updated 4-Jan-12 11:12am

Wonde Tadesse

v2

Add a Solution

Comments

senguptaamlan 4-Jan-12 7:34am

please, explain a bit more...

K N R 4-Jan-12 7:39am

I have 10000 records in a datatable and i am deleting those records. When ever i am deleting those records that's taking a too much time to delete. so could you please tell me if there is a any better way to delete the records quickly

incaunu 4-Jan-12 7:55am

Try calling the dtxml.AcceptChanges(); after the loop is done.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

fjdiewornncalwe · Answer 1 · 2012-01-04T10:10:00

Solution 1

Your .AcceptChanges() call should not be performed after every action. This is causing overhead on every iteration that only should be done once at the end of the process. Move it outside of and directly after your foreach loop.

Posted 4-Jan-12 10:10am

fjdiewornncalwe

Comments

Wendelius 4-Jan-12 17:11pm

That should help a lot.

Wendelius · Answer 2 · 2012-01-04T11:09:00

Another possibility could be that you define a query which returns the rows you want to have in the result and using a dataview you create a new datatableFor example something like (just a sketch):

C#

DataView testView = new DataView(dtxml);
testView.RowFilter = "...";
DataTable testTable = TestView.ToTable("NewTable");