need help for sample data entry

Question

2.00/5 (1 vote)

See more:

SQL-Server-2005

Good day every one

please I need help in coding this small easy program

it just three text boxes and one button to save them

this is my code

Imports System.Data
Imports System.Data.SqlClient



Public Class Form1

    Dim cmd As SqlCommand
    Dim con As SqlConnection
   
    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        Dim ConID As String
        Dim ConAddress As String
        Dim ConPhone As String

        ConID = Me.TextBox1.Text
        ConAddress = Me.TextBox2.Text
        ConPhone = Me.TextBox3.Text
        Try


            con.ConnectionString = "Data Source=DBS;Initial Catalog=Recruitment ;User Id=myuserid;Password=Mypassword"
            con.Open()
            cmd.Connection = con
            cmd.CommandText = "INSERT INTO Contacts(ConID, ConAddress,ConPhone ) VALUES('" & ConID & "' , '" & ConAddress & "' , '" & ConPhone & "') "
        Catch ex As Exception
            MessageBox.Show("Error while inserting record on table..." & ex.Message, "Insert Records")
        Finally
            con.Close()
        End Try



    End Sub

End Class

Posted 17-Aug-11 1:30am

omar aslani

Add a Solution

3 solutions

Solution 1

If conID is numeric, you need not enclose it in quotes.

SQL

"INSERT INTO Contacts(ConID, ConAddress,ConPhone ) VALUES(" & ConID & " , '" & ConAddress & "' , '" & ConPhone & "') "

Suggestion: You should use command with parameters or procedures.

Posted 17-Aug-11 1:36am

Prerak Patel

Solution 2

not working :(

it keeps telling me this error

" Error while inserting on table... Object Reference not set to an instance of an object "

what is that mean ?

Posted 17-Aug-11 1:45am

omar aslani

Comments

nagendrathecoder 17-Aug-11 8:26am

Debug your code and tell us exactly on which line it is throwing exception.

omar aslani 17-Aug-11 8:41am

test.exe!test.Form1.Button1_Click(Object sender, System.EventArgs e) Line 29 Basic

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2011-08-17T08:34:00

First of all, use parameters in your statement, don't concatenate literals to the SQL text. More info, see: SqlParameter [^]. When you use parameters, you don't have to worry for example about data type conversions etc.

The problem looks like that you define the connection and the command variables but you don't create instances of those classes at all. So try changing to:

VB

Dim con As New SqlConnection
Dim cmd As New SqlCommand

Another thing is that you set the sql statement but based on your code you don't execute it at all. Use ExecuteNonQuery[^] to actually execute the statement