cannot implicitly convert type int to an explicit convertion exits (are you missing a cast)

Question

1.00/5 (1 vote)

See more:

C#

public enum error
      {
          Info = 0,
          Warg = 1,
          ErrMsg = 2
      }

//// case 2,case there shows the following error
// cannot implicitly convert type int to an explicit convertion exits (are you missing a cast)

C#

switch (error)
               {
                   case 0:
                       Travel.ErrMsgLblForeColor = Color.Green;
                       break;
                   case 2:
                       Travel.ErrMsgLblForeColor = Color.Yellow;
                       break;
                   case 1:
                       Travel.ErrMsgLblForeColor = Color.Firebrick;
                       break;
               }

please help me

Posted 18-Jul-11 7:47am

ken A to Z

Updated 18-Jul-11 7:48am

Add a Solution

Comments

[no name] 22-Jul-11 10:53am

You have defeated the very purpose of Enum in C#. One of the main objectives behind the design of the C# language is to catch as many exceptions during compilation itself, rather that leave it to the runtime to handle. That is why C# compiler does not allow you to compile this code.

4 solutions

Solution 2

Why not

C#

switch(error)
{
  case error.Info: ...
  case error.Warg: ...
  case error.ErrMsg: ...
}

Posted 18-Jul-11 7:53am

Kim Togo

Comments

walterhevedeich 18-Jul-11 17:50pm

Good point.

Solution 4

Very bad unsupportable code. Why do you think Color is the same as integer? Why do you use immediate constants instead of enumerations? Imaging you change declaration— Also, you could declare array of colors indexed by values of error severity, instead of switch.

—SA

Posted 18-Jul-11 11:38am

Sergey Alexandrovich Kryukov

Comments

Kim Togo 19-Jul-11 11:39am

Good advice. My 5.

Sergey Alexandrovich Kryukov 19-Jul-11 16:00pm

Thank you, Kim
--SA

Solution 3

Probably best to also include

default:
  throw new ArgumentException("Unexpected value found...");

that way you are more likely to trap scenarios where a new value is added to the error enum in future and you have forgotten to update all your code.

Posted 18-Jul-11 8:13am

Reiss

Comments

DaveyM69 18-Jul-11 17:18pm

Or better still, an InvalidEnumArgumentException: http://msdn.microsoft.com/en-us/library/97x53xzc.aspx

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DaveyM69 · Accepted Answer · 2011-07-18T07:52:00

Solution 1

You should use:

C#

case Info:
    // 
    break;
case Warg:
    //
    break;
case ErrMsg:
    //
    break;

If there is a valid reason to use an int then:

C#

switch ((int)error)
{
    //
}

... but this is rarely needed.

Posted 18-Jul-11 7:52am

DaveyM69

Updated 18-Jul-11 7:54am

v2

Comments

#realJSOP 18-Jul-11 14:04pm

5 - 1st correct answer

walterhevedeich 18-Jul-11 17:50pm

5ed too.

VJ Reddy 1-Jun-12 19:48pm

My 5!