How do I solve such an error "no value given for one or more required parameters."

Question

1.00/5 (2 votes)

See more:

I AM TRYING TO UPDATE DATA IN A DATABASE...ACCESS DATABASE TO BE PRECISE, AND IT IS THOWING ME AN ERROR ABOVE HOW DI SOLVE IT

What I have tried:

public String UpdateData(String TableName, String ColumName, int WhatToInsert, String UpdatedInfo)
{
    String item;
    OleDbConnection connection = new OleDbConnection();
    connection.ConnectionString = ("Provider=Microsoft.ACE.OLEDB.12.0;Data Source=|DataDirectory|Rental_database .accdb");
    connection.Open();
    item = "UPDATE ["+TableName+"] SET  ["+ColumName+"]="+UpdatedInfo+" WHERE [ID]="+WhatToInsert+"";
    OleDbCommand command = new OleDbCommand(item, connection);
    command.ExecuteNonQuery();
    connection.Close();
    return item;
}

Posted 11-Jan-23 16:58pm

Member 15883296

Updated 11-Jan-23 18:06pm

Add a Solution

Comments

Graeme_Grant 11-Jan-23 23:56pm

Please DO NOT SHOUT, it is rude. Always use normal sentence case!

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Graeme_Grant · Answer 1 · 2023-01-11T18:06:00

You are not correctly using the OleDbCommand object. Here is a Google Search that will explain how to use it correctly: c# how to use OleDbCommand[^].

Also, as mentioned in your last question, you should never put values into the query string. Doing so opens you to SQL injection attacks[^].

Here is how to update using OleDbCommand:

C#

cmd = new OleDbCommand();
cmd.CommandType = CommandType.Text;
cmd.CommandText = $"UPDATE {TableName} SET {ColumName} = @value WHERE ID = @id";
cmd.Parameters.AddWithValue("@id", WhatToInsert);
cmd.Parameters.AddWithValue("@value", UpdatedInfo);
cmd.Connection = connection;
connection.Open();
cmd.ExecuteNonQuery();
{
    MessageBox.Show("Update Success!");
    cn.Close();`
}