Click here to Skip to main content
15,867,971 members
Please Sign up or sign in to vote.
1.00/5 (2 votes)
See more:
#include <stdio.h>
int main()
{

    float a, b;
    char command;

    printf("Enter a \n");
    scanf("%f", &a);

    printf("Enter b \n");
    scanf("%f", &b);

    printf("Enter your command \n");
    scanf("%c", &command);

    printf("Enter your command \n");
    scanf("%c", &command);

    float add, multiply, divide, subtract;

    // scanf("%c",&command);
    if (command == '+')
    {

        printf("%f \n", a + b);
    }
    if (command == '-')
    {

        printf("%f \n", a - b);
    }
    if (command == '*')
    {

        printf("%f \n", a * b);
    }
    if (command == '/')
    {

        printf("%f \n", a / b);
    }

    float a_result;
    a_result = a + b, a - b, a * b, a / b;
    float c;
    printf("Enter your c \n");

    scanf("%f", &c);
    printf("Enter your command \n");
    scanf("%c", &command);
    printf("Enter your command \n");
    scanf("%c", &command);

    if (command == '+')
    {

        printf("%f \n", a_result + c);
    }
    if (command == '-')
    {

        printf("%f \n", a_result - c);
    }
    if (command == '*')
    {

        printf("%f \n", a_result * c);
    }
    if (command == '/')
    {

        printf("%f \n", a_result / c);
    }

    float b_result;
    b_result = a_result + c;
    b_result = a_result - c;
    b_result = a_result * c;
    b_result = a_result / c;

    float d;
    printf("Enter your d \n");
    scanf("%f", &d);
//RIGHT AFTER HERE PROBLEM STARTS 

    printf("Enter your command \n");
    scanf("%c", &command);
    printf("Enter your command \n");
    scanf("%c", &command);

    if (command == '+')
    {

        printf("%f \n", b_result + d);
    }
    if (command == '-')
    {

        printf("%f \n", b_result - d);
    }
    if (command == '*')
    {

        printf("%f \n", b_result * d);
    }
    if (command == '/')
    {

        printf("%f \n", b_result / b);
    }

    return 0;
}


What I have tried:

I tried to make a calculator without loops but but in my fourth phase after printing by d I am not getting the desired result;
Posted
Updated 30-Jul-22 23:04pm
Comments
Patrice T 30-Jul-22 20:53pm    
And you think you can tell use what is the 'desired result' or it is a secret ?

C++
a_result = a + b, a - b, a * b, a / b; // whatever you think this code is dfoing it probably is not.
// the actual result will be a / b.

You have a similar issue at:
C++
float b_result;
b_result = a_result + c;
b_result = a_result - c;
b_result = a_result * c;
b_result = a_result / c;
 
Share this answer
 
Comments
merano99 31-Jul-22 8:09am    
Exactly that, and the suggestion to use switch-case instead of the countless if queries. +5
Richard MacCutchan 31-Jul-22 8:49am    
I do wonder at what people are actually being taught before they are given these assignments.
There are some unused variables that shouldn't be:

warning C4101: "multiply": Unreferenzierte lokale Variable
warning C4101: "divide": Unreferenzierte lokale Variable
warning C4101: "add": Unreferenzierte lokale Variable
warning C4101: "subtract": Unreferenzierte lokale Variable

Then there are the passages that Richard has already noted.

Instead of the many if queries with a calculation in the output, it would make a lot of sense to use swichr-case and initially only do the calculation and ONE output with the result at the end.

C
float a_result=0.0;

switch(command) {
   case '+':
      a_result = a + b;
      break;
   case '-':
      a_result = a - b;
      break;
   case '*':
      a_result = a * b;
      break;
   case '/':
      a_result = a / b;
      break;
   default:
      puts("no valid result");
}

printf("%f \n", a_result);
 
Share this answer
 
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS


CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900