Exception details: system.data.sqlclient.sqlexception: incorrect syntax near '('.

Question

0.00/5 (No votes)

See more:

I am getting below error when I run the code to update the table records.
I am able to achieve same with same update statement in different page but for some reason it gives error -

Exception Details: System.Data.SqlClient.SqlException: Incorrect syntax near '('.

Your help will be highly appreciated!

What I have tried:

ASP.NET

<pre>protected void SaveBtn_Click(object sender, EventArgs e)
        {
            SqlConnection con = new SqlConnection(strcon);
            con.Open();
            SqlCommand cmd = new SqlCommand("UPDATE project_table SET (project_language = @project_language, project_startdate = @project_startdate, project_enddate = @project_enddate, project_efforts = @project_efforts, project_status = @project_status) WHERE project_name =  '" +  DropDownList1.SelectedItem.Text + "' ", con);
            cmd.Parameters.AddWithValue("@project_language", LanguageDropDown.SelectedItem.Text);
            cmd.Parameters.AddWithValue("@project_startdate", StartDateTxt.Text);
            cmd.Parameters.AddWithValue("@project_enddate", EndDateTxt.Text);
            cmd.Parameters.AddWithValue("@project_efforts", EffortsTxt.Text);
            cmd.Parameters.AddWithValue("@project_status", StatusDropDown.SelectedItem.Text);
            cmd.ExecuteNonQuery();
            
            Response.Write("<script>alert('Details Saved Successfully');</script>");
            LanguageDropDown.ClearSelection();
            EndDateTxt.Text = "";
            StatusDropDown.ClearSelection();
            StartDateCalendar.Visible = false;
            EffortsTxt.Text = "";
        }

Posted 16-Apr-22 11:31am

Foody Tummy

Updated 16-Apr-22 22:23pm

Add a Solution

Comments

DevilCow 16-Apr-22 19:42pm

I think you need to put quotes around `project_language` (actually I think you need to quote all of them) at the beginning of the `UPDATE`

George Swan 17-Apr-22 2:19am

There seems to be a missing double quotation mark surrounding the single quotation mark here:- WHERE project_name = '" +

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2022-04-16T21:15:00

Solution 1

There is no open bracket in an UPDATE command:

SQL

UPDATE MyTable SET MyColumn = @MyParameter, MyOtherColumn = @MyOtherParamater, ... WHERE ...

But since the rest of the command uses Parameter, the WHERE clause should also, or the whole operation is still open to SQL Injection.

Posted 16-Apr-22 21:15pm

OriginalGriff

Foody Tummy · Accepted Answer · 2022-04-16T22:23:00