Why I cannot count the occurence of a particular characetr in string?

Question

0.00/5 (No votes)

See more:

for example if string is apple and the character p should be searched in string. Then the output should be 2 since two p is there
But i am getting 0 as the output

What I have tried:

#include<stdio.h>
#include<stdlib.h>
#include<string.h>
int main()
{
    char str[101];
    scanf("%s",str);
    char ch;
    scanf("%c",&ch);
    int count=0;
    for(int i=0;i < strlen(str);i++){
        if(str[i]==ch){
            count+=1;
        }
    }
    printf("%d",count);

}

Posted 16-Mar-22 9:28am

sanjay surya

Updated 16-Mar-22 10:46am

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2022-03-16T09:50:00

Did you forgot a & ?

C++

scanf("%s",&str);

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

k5054 · Answer 2 · 2022-03-16T10:45:00

Be careful with scanf(). In particular scanf("%s", str) reads from the standard input up to the first white-space character, which is not removed from the input string. The next time you call scanf(), you ask for the next character in the input, which is likely to be the newline char you entered when you typed in "apple". So your program is now counting the number of newline ('\n') characters in the input string. You can fix this by changing the scanf() call to scanf("%s\n", str);.

OriginalGriff · Answer 3 · 2022-03-16T10:46:00

Simple. This line:

scanf("%s",str);

Reads up to the first whitespace, not the end of the line.
So the second scanf returns the newline character which isn't in the target line.
Instead, use fgets[^]

But ... it should have been fairly obvious that something was wrong with the input when you typed "apple" and pressed ENTER and immediately got a result at all ... Look at all the symptom of what happens, and it's easier to work out what is wrong!

Why I cannot count the occurence of a particular characetr in string?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0