How do I use async and await in winform app

Question

0.00/5 (No votes)

See more:

, +

i have created windows form application with c# and sql server 2019
i have atable inside my sql server database named InevtoryCode
i want to update my table with async and await . the problem is my code already run but i think thats is not the perfect way to update my table with async and await.
so can any one help me to make my code more cleaner

What I have tried:

C#

public async Task<inventorystore> UpdateStoreAsync(InventoryStore inventory)
        {
            InventoryStore updatedStore = await UpdateInventoryWithAwait(inventory);
            return updatedStore;
        }
        private async Task<inventorystore> UpdateInventoryWithAwait(InventoryStore inventory)
        {
            //validations
            if (string.IsNullOrWhiteSpace(inventory.Name))
            {
                throw new ApplicationException("Name is required");
            }
            var updatedInventory = _db.Inventories.Find(inventory.Id);
            updatedInventory.Name = inventory.Name;
            updatedInventory.AccountNumber = inventory.AccountNumber;
            updatedInventory.CostOfGoodSoldAccountNumber = inventory.CostOfGoodSoldAccountNumber;
            _db.SaveChanges();
            return updatedInventory;
        }

Posted 25-Nov-21 7:34am

Abuamer

Updated 25-Nov-21 22:45pm

Maciej Los

v3

Add a Solution

Comments

Maciej Los 25-Nov-21 14:50pm

As to me - you don't really need this.

Abuamer 25-Nov-21 15:40pm

please more explain

#realJSOP 26-Nov-21 4:15am

He means you don't need await. It's unnecessary.

Abuamer 26-Nov-21 5:56am

No it works fine

BillWoodruff 25-Nov-21 23:38pm

What happens now when you run your code ? Errors ? Unexpected bresults ?

Abuamer 26-Nov-21 5:56am

No it works fine

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2021-11-25T22:45:00

Entity Framework provides async methods for various operations. Your code should use those.

C#

public async Task<InventoryStore> UpdateStoreAsync(InventoryStore inventory)
{
    if (string.IsNullOrWhiteSpace(inventory.Name))
    {
        throw new ArgumentException(message: "Name is required", paramName: nameof(inventory));
    }

    var updatedInventory = await _db.Inventories.FindAsync(inventory.Id);
    if (updatedInventory is null)
    {
        throw new ArgumentException(message: $"Inventory store {inventory.Id} does not exist", paramName: nameof(inventory));
    }
    
    updatedInventory.Name = inventory.Name;
    updatedInventory.AccountNumber = inventory.AccountNumber;
    updatedInventory.CostOfGoodSoldAccountNumber = inventory.CostOfGoodSoldAccountNumber;
    await _db.SaveChangesAsync();
    
    return updatedInventory;
}