Select query to update

Question

1.00/5 (1 vote)

See more:

VB

SELECT p1.ID, p1.Price,
(SELECT SUM(p2.Price) FROM Products p2 WHERE p1.ID >= p2.ID) as RunningTotal
FROM Products p1
WHERE RunningTotal <= 5000

I found this query and would like to use it to update the records themselves
Any conversion from select to update

What I have tried:

update Products set p1.g = "ok" where (SELECT p1.ID, p1.Price,
(SELECT SUM(p2.Price) FROM Products p2 WHERE p1.ID >= p2.ID) as RunningTotal
FROM Products p1
WHERE RunningTotal <= 5000)

Posted 14-Aug-21 1:53am

Member 14064710

Updated 14-Aug-21 3:12am

Add a Solution

2 solutions

Solution 1

Probably, you should use an UPDATE JOIN rather than SELECT subqueries: SQL Server UPDATE JOIN Explained By Practical Examples[^]

Posted 14-Aug-21 2:35am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2021-08-14T03:12:00

Solution 2

If I understand the query correctly, you could also try

SQL

UPDATE Products
SET    g = "ok" 
WHERE  5000 > (SELECT SUM(p2.Price) 
               FROM   Products p2 
               WHERE   products.ID >= p2.ID)

Posted 14-Aug-21 3:12am

Wendelius

Comments

Afzaal Ahmad Zeeshan 14-Aug-21 16:15pm

5ed.

Wendelius 16-Aug-21 23:04pm

Thanks

Member 14064710 16-Aug-21 6:32am

The code works fine but when using 25,000 records the display was slow, is there a way to be faster,
database is sqlite
thanks

Wendelius 16-Aug-21 23:05pm

One thing to ensure is that you have proper indexing in place. For example check that ID field is indexed in products table.

For more information about indexes, see CREATE INDEX[^]