Does this semicolon cause any issue in struct definition in C++

Question

0.00/5 (No votes)

See more:

I am looking at a legacy code and always see such coding style:

struct SHomog
	{
	public:
		SHomog(T _x=0, T _y=0, T _w=1)
     	{ 
          x=_x; y=_y; w=_w;
        };	<=== this semicolon causes any issue?

		T x;
		T y;
		T w;
	};

in my understanding, this semicolon following } sign will not cause any issue, but this full code page is put into a header file and filled with such extra semicolons and I suspect it is causing issue.

any advice and experience to share?

What I have tried:

one error message is as below:

Quote:
Severity Code Description Project File Line Suppression State
Error C2334 unexpected token(s) preceding '{'; skipping apparent function body

Posted 25-Mar-21 8:05am

Southmountain

Updated 25-Mar-21 8:46am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Greg Utas · Accepted Answer · 2021-03-25T08:46:00

Solution 1

That semicolon is redundant but shouldn't cause a problem. If I add

typedef int T;

and remove your question from the code, it compiles without any warnings at all under VS2017.

The convention is usually to use an underscore in a class member, not a parameter, but I don't see anything wrong with the code.

Posted 25-Mar-21 8:46am

Greg Utas

Comments

Southmountain 25-Mar-21 15:15pm

sorry I skipped few statements as this:

template <class T>
class TLineApproximator  
{
public:
	//! \name Structures and typedefs
	//@{
	//! 2D homogenous point
	struct SHomog
	{
	public:
		SHomog(T _x=0, T _y=0, T _w=1)	{ x=_x; y=_y; w=_w;};	
			T x;
			T y;
			T w;
     	};
//skip few lines

Greg Utas 25-Mar-21 15:26pm

I can't see how it would matter if it's located in a template, although the template needs a closing };

Southmountain 29-Mar-21 12:20pm

thank you for your input:) I think I find the reason: the code used template style before 2003, now it has conformance issue...