In C++ I want to get in cnic number...if I enter more then 13 number.it have to show a message that number of integers is more the given space.

Question

0.00/5 (No votes)

See more:

In c++ i want to get in cnic number...if i enter more then 13 number.it have to show a message that number of integers is more the given space.

#include<iostream>
#include<conio.h>
using namespace std;
int main()
{
	
	int cnic,a=0;
	
	while (cnic[a]!='/0')
	{
	cin>>cnic;
	a++;
	}
	if(a==12)
	cout<<"valid";
	else 
	cout<<"Invalid";
	return 0;
}

What I have tried:

#include<iostream>
#include<conio.h>
using namespace std;
int main()
{
	
	int cnic,a=0;
	
	while (cnic[a]!='/0')
	{
	cin>>cnic;
	a++;
	}
	if(a==12)
	cout<<"valid";
	else 
	cout<<"Invalid";
	return 0;
}

Posted 25-Nov-18 3:35am

Member 14066370

Updated 20-Mar-21 0:50am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Afzaal Ahmad Zeeshan · Answer 1 · 2018-11-25T03:55:00

Solution 1

You need to be using array instead of a value type variable,

C++

int cnic,a=0;

That will be changed to,

C++

int cnic[13];
int a = 0;

This will be a container, that can contain 13 values. And also, you might want to take a look at do...while, instead of while loops as I believe that is what you are looking for, as your code won't work as you are expecting it to work. And moreover, '\0' is what you are looking for, not '/0'. :laugh:

A simple tip would be, consider using a for(;;) loop instead of this while loop.

So much to learn brother, please follow the following links and explore a bit more of C++,
Arrays - C++ Tutorials[^]
loops - The difference between while and do while C++? - Stack Overflow[^]
c# - 'do...while' vs. 'while' - Stack Overflow[^]

Posted 25-Nov-18 3:55am

Afzaal Ahmad Zeeshan

Comments

Richard MacCutchan 25-Nov-18 10:09am

I think it would be better to declare cnic as char type for this problem.

Afzaal Ahmad Zeeshan 25-Nov-18 11:34am

Yes, but mostly here we store 13 digit values for the CNIC which are numbers. The dashes are placed afterwards, as a mask. So that is why I did not pay much attention to that part. A normal CNIC over here is 12345-1234567-1.

But yes you are right, it could be character data type, and 15 length.

Richard MacCutchan 25-Nov-18 12:45pm

It just occurred to me (after reading the Wikipedia entry for CNIC) that storing as char type would make it easier to split out the two major fields and convert them to their numeric values, or compare them against whatever rules are in force.

[no name] 22-Mar-21 5:44am

sir! how can i add cnic number in c++ for ATM machine?

[no name] 22-Mar-21 3:45am

How can i add cnic number in c++ program to ATM ? Anyone plz help me

Afzaal Ahmad Zeeshan 23-Mar-21 12:38pm

Please create a new thread to ask a new question.

Which ATM is this, are you using some sort of SDK, to write this program or writing your own? Please create a new thread and ask this question there with more details.