Expected unqualified-id before ‘{’ token

Question

1.00/5 (1 vote)

See more:

I kept running over this error. But I can't find it in the code.

#include<stdio.h>
long factorial(int num); //Function declaration
int main()
{
int num;
long fact;
printf("Enter a number to find factorial: ");
scanf("%d", num);
if(num<0)
printf("Factorial of negative no. is not defined. \n") ;
else
{
fact = factorial(num);
printf("%d!=%d \n", num, fact);
}
return 0;
}
//Function definition
long factorial(int num);
{
    {

if(num==0) 
return 1;

else


return(num*factorial(num-1);
}
}

What I have tried:

I know it's a syntax problem, but can someone here help me.

Posted 16-Feb-21 23:54pm

Member 15074855

Updated 17-Feb-21 2:45am

Add a Solution

4 solutions

Solution 2

read the error message carefully because also the line number is mentioned.

I guess:

C

//Function definition
long factorial(int num);//TODO remove ;
{

Posted 16-Feb-21 23:59pm

KarstenK

Comments

Member 15074855 17-Feb-21 6:25am

I did remove it, but it still has a lot of error.

KarstenK 17-Feb-21 7:52am

read the error message en detail and start with the FIRST. This is very important, because some errors triggering other errors.

Solution 4

Looking at this and your Java question, you appear to be trying to write code in both languages without really understanding the basics of either of them. You would do well to focus on just one, and spend some (a lot of) time actually learning the syntax and other rules.

For Java see The Java™ Tutorials[^].

For C++ see Learn C++[^]

Posted 17-Feb-21 2:45am

Richard MacCutchan

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2021-02-16T23:59:00

Solution 1

Quote:

C++

long factorial(int num);
{
    {

if(num==0) 
return 1;

else


return(num*factorial(num-1);
}
}

Remove the trailing ; from the first line of the function.

You then have a stray unmatched ( on the return line.

And you have some extra braces within your function which aren't needed.

Also, indent your code properly. It will make it much easier to read.

C++

long factorial(int num)
{
    if (num == 0) return 1;
    return num * factorial(num-1);
}

Posted 16-Feb-21 23:59pm

Richard Deeming

Comments

Member 15074855 17-Feb-21 6:10am

This worked, thank you so much. I'll take note of that.

Member 15074855 17-Feb-21 6:24am

Just want to ask my program was supposed to show the factorial, but this code ain't doing it.

Richard Deeming 17-Feb-21 6:31am

Well, you have an error in your scanf call - it should be:

scanf("%d", &num);

scanf - C++ Reference[^]

You also need to use %ld on the printf line to output the fact variable:

printf("%d!=%ld \n", num, fact);

Member 15074855 17-Feb-21 6:41am

Okay thank you, noted.

CPallini · Accepted Answer · 2021-02-17T00:00:00

Quote:
//Function definition
long factorial(int num); // <-- REMOVE THE SEMICOLON
{
{

[update]
Try

C++

#include<iostream>
  
using  namespace std;
long factorial(int num); //Function declaration
int main()
{
  int num;
  long fact;
  printf("Enter a number to find factorial: ");
  scanf("%d", &num);
  if( num < 0 )
    printf("Factorial of negative no. is not defined. \n") ;
  else
  {
    fact = factorial(num);
    printf("%d!=%ld \n", num, fact);
  }
  return 0;
}

//Function definition
long factorial(int num)
{
  if(num==0)
    return 1;
  else
    return(num*factorial(num-1));
}

[/update]