How do I fix this multiplication program?

Question

0.00/5 (No votes)

See more:

We have an activity to program, but I am not good in programming so I would like to ask for your help. We are tasked to code a c program but my program does not run. Below is the instructions of our activity.

Design a flowchart and make a C program that will perform multiplication from user-given multiplicand (positive integer) and multiplier (positive integer) using repeated addition.

Example:
Enter Multiplicand: 4 Enter Multiplier: 3
The product is: 12

Enter Multiplicand: 4 Enter Multiplier: -3
INVALID INPUT

What I have tried:

C++

#include <stdio.h>
const int;
int main()
for (int i = 0; i <= max_values; i++) {
    int a,b;
    int mul,loop;
     
    printf("Enter Multiplicand: ");
    scanf("%d",&a);
    printf("Enter Multiplier: ");
    scanf("%d",&b);
     
    mul=0;

    for(loop=1;loop<=b;loop++){
        mul += a,b;
        
    printf("The product is: %d\n",mul);
    }
else {
        fprintf(stderr, "INVALID INPUT\n");
    }
    

    return 0;
}

Posted 15-Dec-20 23:52pm

Member 15022607

Updated 16-Dec-20 0:31am

Patrice T

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2020-12-16T00:18:00

Try

C

#include <stdio.h>
int main()
{
  int a, b;
  int c;
  do
  {
    printf("Enter Multiplicand: ");
    scanf("%d",&a);
    printf("Enter Multiplier: ");
    scanf("%d",&b);

    if ( a < 0 || b < 0 )
    {
      printf("Invalid input\n");
    }
    else
    {
      int mul = 0;
      for(int i=0; i<b; ++i)
        mul += a;

      printf("The product is: %d\n",mul);
    }

    printf("enter '1' to continue\n");

    scanf("%d", &c);
  }  while  (c == 1);

    return 0;
}

[Update]
Fixed the missing check on input a, thanks to KarstenK.
[/Update]

Richard MacCutchan · Answer 2 · 2020-12-16T00:25:00

There are a number of simple errors in your code, which could be resolved by reading your notes or checking any of the study guides available online.

C++

#include <stdio.h>
// this line does not mean anything. When you declare a variable you must give it a name.
const int;
int main()
// you have not declared max_values anywhere. Presumably it should be on the line above.
for (int i = 0; i <= max_values; i++) {
    int a,b;
    int mul,loop;
     
    printf("Enter Multiplicand: ");
    scanf("%d",&a);
    printf("Enter Multiplier: ");
    scanf("%d",&b);
     
    mul=0;

    for(loop=1;loop<=b;loop++){
// this line will add the value of a to mul. the reference to b is ignored*.    
        mul += a,b;
        
    printf("The product is: %d\n",mul);
    }
// this else has no corresponding if clause.
else {
        fprintf(stderr, "INVALID INPUT\n");
    }
    

    return 0;
}

* thanks to Karsten for pointing out my mistake.

OriginalGriff · Answer 3 · 2020-12-16T00:31:00

To add to what CPallini says, why is a negative number an invalid value?

3 * -1 == -3
3 * -2 == -6
...
-3 * 1 == -3
-3 * 2 == -6
...
-3 * -1 == 3
-3 * -2 == 6
...

Instead of rejecting negative inputs, you should be working out the sign of the result, using the absolute values of the inputs, and applying the sign to the product you generate.

It would also be an idea to ensure that the lowest value is used as the loop guard, or 2 * 100000000 will take a lot longer to evaluate than 100000000 * 2.

It might also be worth looking at implementing a decimal or binary version of "long multiplication" if you want efficiency with larger numbers:

69 * 72 == 690 * 7 + 69 * 2

How do I fix this multiplication program?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0