Problem in datetime format in C# winform

Question

3.00/5 (1 vote)

See more:

i try use DateTime format show in "dd/MM/yyyy HH:mm:ss" Like "06/06/2020 20:06:55"

but i failed can any one help me

my code is :

String date = DateTime.Now.ToString("dd/MM/yyyy HH:mm:ss");
DateTime fullDate = Convert.ToDateTime(date);

string fileSavepath = "" + folderPath + "Report -" + fullDate.Day + "-" + fullDate.Month + "-" + fullDate.Hour + "-" + fullDate.Minute + "-" + fullDate.Second + ".xlsx";

wb.SaveAs(fileSavepath);

What I have tried:

when i use debugging
my first string output datetime correct format, but after second datetime fullDate output wrong format

i want when i save file it's save "Report -06-06-20-06-55" but it's save now "Report -6-6-20-6-55"

Posted 6-Jun-20 4:47am

Amar chand123

Updated 6-Jun-20 5:13am

Add a Solution

Comments

MadMyche 6-Jun-20 12:08pm

Just a recommendation... I would format using one a canonical datetime patterns which will allow for natural sorting by name as well as date.
I personally use something along the lines of Filename_20201231-181005.ext

Amar chand123 6-Jun-20 22:43pm

Thank you i try

KarstenK 6-Jun-20 13:36pm

Nice tip - if I write files I do it similar.

2 solutions

Solution 1

Why?
DateTime.Now is already a DateTime value ... so why convert that to a string, just to convert it back to a DateTime - especially as you specify a format to the ToString but use the system default for the Convert?
Just use DateTime.Now directly:

DateTime now = DateTime.Now;
string formattedDate = $"Report -{now.Day:00}-{now.Month:00}-{now.Hour:00}-{now.Minute:00}-{now.Second:00}";
string fileSavePath = Path.Combine(folderPath, formattedDate + ".xlsx");

Note: I copy DateTime.Now into a variable - this is important as multiple reads of DateTime.Now can give consistency problems around midnight!

Posted 6-Jun-20 5:06am

OriginalGriff

Updated 6-Jun-20 5:07am

v2

Comments

Amar chand123 6-Jun-20 11:34am

First i try only datetime filldate = datetime.now but it's not working than i try Google for solutions then i find this so i try but its also not work then i place question here because here i always learn new

OriginalGriff 6-Jun-20 11:53am

C# is case sensitive:
datetime filldate = datetime.now
is not valid:
DateTime filldate = DateTime.Now;
Is.

Amar chand123 6-Jun-20 12:15pm

Sir i try DateTime filldate = DateTime.Now; in this comment i only typed in smallcase

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2020-06-06T05:13:00

Solution 2

Why are you converting DateTime.Now to a string just to convert it back to a DateTime object? All you need to do to create your filename is:

C#

string filename = string.Format("Report -{0}.xlsx", DateTime.Now.ToString("dd-MM-hh-mm-ss"));
string fileSavepath = Path.Combine(folderPath, filename);

Posted 6-Jun-20 5:13am

Richard MacCutchan

Comments

Amar chand123 6-Jun-20 11:38am

Thank you for answering sir Richard and why i convert string to datetime and again datetime because when i try Google i found some said so i just try

Richard MacCutchan 6-Jun-20 11:53am

Don't rely on Google to write your code. Spend some time actually learning the language.

Amar chand123 6-Jun-20 12:11pm

I am new in language so when i have any problem i try search solutions on Google and now i everyday spend one hour on YouTube for learning language

Richard MacCutchan 6-Jun-20 12:15pm

Well all those hours are probably wasted. Get yourself a proper book on C# and learn from there.

Amar chand123 6-Jun-20 12:22pm

Thank you for suggestions now I think i really need a book of learning language after lockdown i go and buy a book

Richard MacCutchan 6-Jun-20 12:26pm

In the meantime you can make use of Microsoft's official pages. See C# Tutorials | Microsoft Docs[^].

Amar chand123 6-Jun-20 12:27pm

Thank you