Image source change on click issues

Question

0.00/5 (No votes)

See more:

Not really a javascript guy and trying to get this simple image.src to change...
I have 3 mjpegs as sources that i want to alternate through when i click the image so far when i test on my webserver nothing happens with a click() when i test on JSFiddle.net it changes the image on the first click then nothing after that.
Any help appreciated.

HTML

<img id="mjpeg" src="http://ipaddress:8100/Mjpeg/0?authToken=abccb262-c400-4205-81e4-73ce28134d13" 
onclick="changeImage()"  width="704" height="480"/>

changeImage = function() {
    var image = document.getElementById('mjpeg');
                                                      
    if (image.src.match("/0?")) {
       image.setAttribute('src', "http://ipaddress:8100/Mjpeg/1?authToken=abccb262-c400-4205-81e4-73ce28134d13");
    } 
    else if (image.src.match("/1?")) {
       image.setAttribute('src', "http://ipaddress:8100/Mjpeg/2?authToken=abccb262-c400-4205-81e4-73ce28134d13");
    } 
    else if (image.src.match("/2?")) {
       image.setAttribute('src', "http://ipaddress:8100/Mjpeg/0?authToken=abccb262-c400-4205-81e4-73ce28134d13");
    } <pre lang="Javascript">

What I have tried:

I have tried matching on the entire src string with no luck

Posted 6-Dec-19 10:38am

Member 9680117

Updated 6-Dec-19 11:33am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 9680117 · Accepted Answer · 2019-12-06T11:34:00

I think i just figured it out by changing the matching function to == rather than .match

JavaScript

if (image.src == "http://ipaddress:8100/Mjpeg/0?authToken=abccb262-c400-4205-81e4-73ce28134d13") {
       image.setAttribute('src', "http://ipaddress:8100/Mjpeg/1?authToken=abccb262-c400-4205-81e4-73ce28134d13");
    } 
    else if (image.src == "http://ipaddress:8100/Mjpeg/1?authToken=abccb262-c400-4205-81e4-73ce28134d13") {
       image.setAttribute('src', "http://ipaddress:8100/Mjpeg/2?authToken=abccb262-c400-4205-81e4-73ce28134d13");
    } 
    else if (image.src == "http://ipaddress:8100/Mjpeg/2?authToken=abccb262-c400-4205-81e4-73ce28134d13") {
       image.setAttribute('src', "http://ipaddress:8100/Mjpeg/0?authToken=abccb262-c400-4205-81e4-73ce28134d13");
    }