If condition is being skipped

Question

1.00/5 (1 vote)

See more:

I have a foreach loop for a winforms datagridview it is hosted inside a wpf usercontrol. The foreach loop skips the first condition automatically declares it a null then runs properly for every row after. The if condition is true.

C#

foreach (DataGridViewRow item in Dashboard_dataGrid.Rows)
    {


        //--[0] is the index of the checkbox Column on the Datagridview
        if (Convert.ToBoolean(item.Cells[0].Value) == true) //if switched to false it works or add true) continue;
        {
            MessageBox.Show("Selected Rows :" + item.Cells[0].RowIndex.ToString()); //just to show where I am at in the index
            sqlCon.Open();

            SqlDataAdapter abc = new SqlDataAdapter("Delete from tbl_ClientProducts Where productID = '" + item.Cells[11].Value.ToString() + "' and  userID = '" + UtilityClass.userID + "'", sqlCon);

            DataTable dtbl = new DataTable();
            abc.Fill(dtbl);
            Dashboard_dataGrid.Update(); //did not work
            Dashboard_dataGrid.Refresh(); // did not work
            sqlCon.Close();
        }

    }
    MessageBox.Show("Your product(s) have been deleted Successfully");

}

What I have tried:

I have changed the condition to false the it evaluates saying there is a null value but its not null .Net has set the cell to null

C#

if (Convert.ToBoolean(item.Cells[0].Value) == false)

Posted 7-Oct-19 7:32am

Member 12349597

Updated 8-Oct-19 10:00am

Patrice T

v2

Add a Solution

Comments

Richard Deeming 7-Oct-19 14:12pm

"Delete from tbl_ClientProducts Where productID = '" + item.Cells[11].Value.ToString() + "' and userID = '" + UtilityClass.userID + "'"

Don't do it like that!

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

SqlDataAdapter abc = new SqlDataAdapter("Delete from tbl_ClientProducts Where productID = @productID and userID = @userID", sqlCon);
abc.SelectCommand.Parameters.Add("@productID", item.Cells[11].Value);
abc.SelectCommand.Parameters.Add("@userID, UtilityClass.userID);

Member 12349597 7-Oct-19 15:32pm

The sql injection will be addressed later this is just to get it working how I want before I move into the App security phase. So now idea about the if condition?

Maciej Los 8-Oct-19 9:44am

You have to develop an application by paying attention on security. You can NOT "improve" application later (as you stated in "security phase)", due to lots of reasons.

Member 12349597 8-Oct-19 11:34am

Your killing me smalls the issue is an if condition being skipped. Your security application theory has been addressed. Do you have any information that may be useful to an if condition being skipped... If not Thank you but not dealing with security at the moment.

F-ES Sitecore 8-Oct-19 4:07am

I don't really understand the question, but the problem is probably because you are trying to change the datasource of something while iterating it. Maybe the issue is that the foreach is iterating over the old data and you are expecting it to iterate over the updated data.

Member 12349597 8-Oct-19 8:39am

I don't think that's it because it works correctly for addition rows so for instance if I have 5 rows the foreach loop will work for 4 and skip the last row. If I only have one row it will skip the row and nothing will happen. But I will see if their may be something along those lines for that one row. Thanks

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2019-10-07T08:20:00

Solution 1

0) As already noted, don't do it that way.

1) Why in the hell are you using a Winforms control in WPF? Just because it "can be done", doesn't mean it should be done.

2) Use the MVVM pattern, and perform appropriate binding(s). You should be able to move your foreach loop into your observable collection, thus abstracting it out of the UI. The whole MVVM thing is too big to fit into an answer here because there are so many variations regarding its implementation, but for sure, the form should not have the foreach code in it.

Posted 7-Oct-19 8:20am

#realJSOP

Updated 7-Oct-19 8:22am

v2

Comments

Member 12349597 7-Oct-19 16:16pm

MVVM in my opinion is to abstract and separation of concerns makes the code really bloated. Also if all you need is a datagridview connected to an excess datatsource why would you break the code into 3 to 4 sections for such a generic task? MVVM documentation regarding datagrid checkbox is rally bad, Plus it works great except for this if condition..... Anyone else think they have a reason

#realJSOP 8-Oct-19 10:04am

You're not bloating code by using MVVM - you're simply moving the code you'd have to write *anyway* into a more logical location.

AntGamble · Answer 2 · 2019-10-07T22:09:00

Solution 3

Hi,

foreach also evaluates the 'new row' if the grid allows the user to add rows.

Check that the row.IsNewRow is false.

Posted 7-Oct-19 22:09pm

AntGamble

Comments

Member 12349597 8-Oct-19 8:36am

Thanks, user cannot add new rows.

Maciej Los · Answer 3 · 2019-10-08T10:01:00

Assuming that datagridview column[0] holds checkbox control... you have to read DataGridViewCheckBoxCell.TrueValue[^] or DataGridViewCheckBoxCell.FalseValue[^]

C#

foreach (DataGridViewRow item in Dashboard_dataGrid.Rows)
    {
        DataGridViewCheckBoxCell chk = (DataGridViewCheckBoxCell)item.Cells[0]; //--[0] is the index of the checkbox Column on the Datagridview
        if (chk.TrueValue) 
        {
           //your logic here...
        }
    }

Note: sometimes it's necessary to check if checkbox value is null.

If condition is being skipped

3 solutions

Solution 1

Solution 3

Solution 4

Add your solution here

Preview 0

Existing Members

...or Join us