Click here to Skip to main content
15,895,799 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
Without this part work fine

and Radnik like '" + notificationLabel.Text + "' ";


What I wrong?

When put code in sql

select datumpodnosenja as 'Datum', radnik as 'Radnik', status as 'Status' from dbo.izlaznice where tip='Izlaznica'and Radnik like '%' <pre><pre>


Have normal result

Some help

What I have tried:

String saveStaff = " select datumpodnosenja as 'Datum', radnik as 'Radnik', status as 'Status' from dbo.izlaznice where tip='Izlaznica' and Radnik like '" + notificationLabel.Text + "' ";
Posted
Updated 30-Oct-18 0:36am

For starters, don't do that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

Then you can look at why it "doesn't work" - and since that's all the info you give us I'll have to guess what that means.
Probably, it's because SQL LIKE without SQL wildcards is identical to SQL =
Which means that if your label text contains "ABC" then your LIKE will only return rows where the column exactly matches "ABC". If you want wildcard comparisons, you have to specify the wildcards!
Try this:
SQL
AND Radnik LIKE '%' + @NL + '%'
And pass notificationLabel.Text as a parameter named @NL
 
Share this answer
 
It depends what you want to happen and what is in notificationLabel.Text. If you want anything where Radnik contains the text then the syntax you need is

WHERE Radnik LIKE '%my text%'

So if notificationLabel.Text contains "my text" then your code needs to be;

String saveStaff = " select datumpodnosenja as 'Datum', radnik as 'Radnik', status as 'Status' from dbo.izlaznice where tip='Izlaznica' and Radnik like '%" + notificationLabel.Text + "%' ";


However you should be using parameterised queries rather than using string concatenation to build your queries. Your code will fail if notificationLabel.Text contains an apostrophe, but more seriously it might make your code liable to SQL injection attacks.
 
Share this answer
 
Comments
Stylus STYLUS 30-Oct-18 6:55am    
In this code datagrid have all vaules from table, not just from notificationLabel.Text

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900