Comments by al13n (Top 2 by date)

al13n 3-Mar-15 4:30am View

OMG please remove your password and user from the code!

al13n 1-Feb-14 5:48am View

Reason for my vote of 1 \n Sorry, but this is not a good example of how to write a C# method. I appreciate the effort, but the code is buggy and confusing in name.

Buggy? How? Any exceptions act as if the string is empty and return 0, silently eating the real cause. (a bad thing)

A method should not hide exceptions, unless they catch specific exceptions and can handle them or wrap them with a clearer exception. They should NEVER catch all exceptions, unless it's the global exception handler.

The method name is confusing at best. Count of what exactly? GetStringLength is much clearer, or GetCharacterCount. I would expect your method called GetStringCount to return me the number of strings, which is obviously not what it does.

In short, the short "good pattern" example would fail a review badly and needs fixing if you wish to present this as a good example to others.

I look forward to amending my vote once you're finished. =)