StackOverFlow error after recursion

Question

0.00/5 (No votes)

See more:

Hey, i have this code

private void putTextOnButtons() {
        for (int i = 0; i < 4; i++) {
            int num = rand.nextInt(10) + 1;
            number[i] = num;
            buttons[i].setText(num + "");
            sortArray(number);
            for (int j = 0; j < 3; j++) {
                if (number[j] == number[j + 1])
                    putTextOnButtons();
            }
            sortArray(number);
        }
    }

But whenever i try to run it, it crashes and says

Process: com.example, PID: 12305<br />
  java.lang.StackOverflowError

and

> at com.example.gal.tapbynumber.EasyMainActivity.putTextOnButtons(EasyMainActivity.java:110)
Which takes to `putTextOnButtons();`
under the if.
I don't see any problem here, Any one can help me please?

Posted 31-Jan-15 11:08am

Member 11417405

Add a Solution

2 solutions

Solution 2

In that case you should use a loop instead of recursivity. In the second loop set a variable that will indicate that there are some duplicates and add an outer loop that use that variable to loop the whole code of necessary.

By the way, it is not a good way to generate unique random numbers as if the sequence is long and generated numbers range is small, it can lead to a lot of retries or even almost infinite loop.

Given that you generated only small number, better to make a list of those and pick a number into that list untl you have all desired numbers.

Similar questions have been asked multilple times, so if you cannot figure it out, you can use Google.

Posted 31-Jan-15 12:50pm

Philippe Mori

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 11417405 · Accepted Answer · 2015-01-31T11:49:00

I have solved it all i had needed to do is change from this

C#

private void putTextOnButtons() {
        for (int i = 0; i < 4; i++) {
            int num = rand.nextInt(10) + 1;
            number[i] = num;
            buttons[i].setText(num + "");
            sortArray(number);
            for (int j = 0; j < 3; j++) {
                if (number[j] == number[j + 1])
                    putTextOnButtons();
            }
            sortArray(number);
        }
    }

to this

C#

private void putTextOnButtons() {
        for (int i = 0; i < 4; i++) {
            int num = rand.nextInt(10) + 1;
            number[i] = num;
            buttons[i].setText(num + "");
            }
            sortArray(number);
            for (int j = 0; j < 3; j++) {
                if (number[j] == number[j + 1])
                    putTextOnButtons();
            }
            sortArray(number);
        
    }