Do the “StreamWriter.WriteLine()” function need to “lock()”?

Question

0.00/5 (No votes)

See more:

Hi,
i develop a class to write logs. it writes with "StreamWriter.WriteLine()" function.

logStream.WriteLine(msgWrite);
logStream.Flush();

some different threads use this class to write logs, in one text file(The log file is common for all threads) do it need to lock() function?

should i change my code?

lock(syncObj)
{
logStream.WriteLine(msgWrite);
logStream.Flush();
}

please help me.

Posted 15-Sep-14 18:34pm

Zon-cpp

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

*Suvabrata Roy* · Answer 1 · 2014-09-15T18:53:00

Yes it needs lock,

How a data write to a stream :

Stream is a pointer which holds some memory now when we write data to file stream data would first store into buffer and then flush to your memory now in between that if two or more threads are working simultaneously then buffer may be replaced by the new data and your file data may show mixed lines.
Because buffer will change on demand and it dose not ensure the data is properly written to the file or not its just a intermediate data holder.

Now lock will come to play for providing synchronized access of file pointers until one thread release the that buffer or complete job on that stream other will wait so there is no data damaged will occur.

Happy Coding...