Should a small custom structure be manually disposed?

Question

0.00/5 (No votes)

See more:

I have this small structure that i use only to manage the contents of some comboboxes instead of a database, by reading from an XML file, but each time the index of another combobox is changed, the contents of the whole combobox gets cleared and refilled, obviously with new structure objects.

At doing this, i know i am removing all the structures from the comboboxes item's list, but the objects are not disposed, as far as i know.

I've created an structure because I read that a structure is good when you are going to instantiate too many small classes, because they are faster at stacking in memory...
In any case im not very familiarized with the structures and also i was trying the new knowledge, so i want to know both things:

Should I make the structure disposable or the GC does it automatically, and also; is this a good use for a structure, or is better to make it a class?

VB

Friend Structure FileRef

    Private _FileName, _Extension, _Path As String

    Public Property Display As String

    Public ReadOnly Property Path As String
        Get
            Return Me._Path
        End Get
    End Property
    Public ReadOnly Property FileName As String
        Get

            Return Me._FileName
        End Get
    End Property
    Public ReadOnly Property Extension As String
        Get


            Return Me._Extension
        End Get
    End Property

    Public Sub New(ByVal path As String)

        Me._Path = path
        Me._Extension = System.IO.Path.GetExtension(Me._Path)
        Me._FileName = System.IO.Path.GetFileName(Me._Path)
    End Sub
    Public Sub New(ByVal path As String, ByVal AutoDisplay As Boolean)

        Me._Path = path
        Me._Extension = System.IO.Path.GetExtension(Me._Path)
        Me._FileName = System.IO.Path.GetFileName(Me._Path)
        If AutoDisplay = True Then _
          Me.Display = System.IO.Path.GetFileNameWithoutExtension(Me.Path)
    End Sub
    Public Sub New(ByVal path As String, ByVal display As String)

        Me._Path = path
        Me._Extension = System.IO.Path.GetExtension(Me._Path)
        Me._FileName = System.IO.Path.GetFileName(Me._Path)
        Me.Display = display
    End Sub

    Public Overrides Function ToString() As String

        If Me.Display = Nothing Then Return Me.Path Else Return Me.Display
    End Function

End Structure

I use it like this:

VB

Private Sub cboCollection_SelectedIndexChanged(sender As Object, e As EventArgs) _
                                    Handles cboCollection.SelectedIndexChanged

        If cboCollection.SelectedIndex >= 0 Then

            Dim SelItem As FileRef = DirectCast _
                                    (cboCollection.SelectedItem, FileRef)

            cboCollection.Items.Clear()
            cboImage.SelectedIndex = -1

            Using fs As New FileStream(SelItem.Path,_
                          FileMode.Open, FileAccess.Read, FileShare.Read)
                Using xmlR As XmlReader = XmlReader.Create(fs)
                   
                    Try 

                    'Code that reads the xml 
                    'and creates in iteration the FileRef objects
                    'to then add them 1 by 1 to another combobox

                    Catch ex As Exception

                    'Error management
                    End Try
                End Using
            End Using
        End If
End Sub

Thanks in advance and sorry if i had bad english.

PS. I wrote in VisualBasic but answers in C# are also very welcome.

Posted 10-May-14 15:48pm

Elighne

Updated 10-May-14 15:49pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2014-05-10T18:27:00

First of all, you should understand the difference between GC action (finalization and reclaiming managed memory) and finalization. Disposal (System.IDisposable) is a separate mechanism which can be used to clean-up everything. It is often used to dispose unmanaged resource, but it is not the only purpose. Basically, if you don't use unmanaged memory or other resources and you don't know what else the disposal is needed for, chance are, you don't need disposal at all.

As to structures vs classes, Solution 1 is quite inaccurate. [EDIT] After out discussion, its author has removed it. [END EDIT]

You can easily compromise performance using structures instead of classes, and the opposite situation is always possible. Also, you should understand that members of reference types can be of value types, and member of structures (value types) can be of reference types. The question "which one to choose" is simply wrong. Instead of asking such questions, you need to get in-depth understanding of reference and value types. The particular decision depends on many factors, starting from your goals. In my experience, people usually screw up things with structures the way it could be fixed by changing a structure to a class, but this is not related to performance and absolutely does not mean that you should ever ignore the possibility of using structures. You should clearly understand what does what. If you had some particular concerns about it, I would gladly answer.

—SA