There is already an open DataReader associated with this Command which must be closed first.

Question

1.00/5 (1 vote)

See more:

SQL-Server-2008

When iam executing the below code getting the error there is already an open datareader associated with this command which must be closed. error help me out

C#

using System.Data;
using System.Data.SqlClient;
using System.Configuration;
public partial class Finaldestination : System.Web.UI.Page
{
    SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["dbconnection"].ConnectionString);
    protected void Page_Load(object sender, EventArgs e)
    {

    }
    protected void Button1_Click(object sender, EventArgs e)
    {
        string strSelect = "SELECT * FROM tblregistration  WHERE UserId = '" + TextBox2.Text + "' ";
        SqlCommand cmdSelect = new SqlCommand(strSelect,con);
        cmdSelect.Parameters.AddWithValue("@UserId", TextBox2.Text);

        cmdSelect.CommandText = strSelect;
        cmdSelect.Connection = con;
        SqlDataReader reader;
        con.Open();
        reader = cmdSelect.ExecuteReader();
        {
            
            if ( reader.HasRows == true)
            {
                con.Close();
                Label1.Text = "Username exists please try other one";
            }
            
            else
            {

                string insert = "insert into tblregistration(Name,UserId,Email,Password,Confirmpassword) values (@Name,@UserId,@Email,@Password,@Confirmpassword) ";
                SqlCommand cmd = new SqlCommand(insert, con);
                cmd.Parameters.AddWithValue("@Name", TextBox1.Text);
                cmd.Parameters.AddWithValue("@UserId", TextBox2.Text);
                cmd.Parameters.AddWithValue("@Email", TextBox3.Text);
                cmd.Parameters.AddWithValue("@Password", TextBox4.Text);
                cmd.Parameters.AddWithValue("@Confirmpassword", TextBox5.Text);
                //con.Open();
                cmd.ExecuteNonQuery();  
                Label1.Text = "data saved";
               
            }
        }

Posted 10-Nov-13 21:46pm

raxhemanth

Updated 10-Nov-13 21:54pm

Thanks7872

v2

Add a Solution

2 solutions

Solution 2

You have to close SqlDataReader when you finished using the it.When SqlDataReader is open, the Connection is in use by it.Hence you cannot execute any commands for that particular connection.

Use reader.Close(); just inside the else block in your code.

Reference : http://stackoverflow.com/questions/16162732/already-an-open-datareader-associated-with-this-command-which-must-be-closed-fir[^]

Posted 10-Nov-13 22:01pm

Thanks7872

Updated 10-Nov-13 22:03pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-11-10T21:54:00

The clue is in the error message:

there is already an open datareader associated with this command which must be closed.

You create a reader, and do not try to dispose of it before you reuse the same connection for the insert command. This is not allowed: http://msdn.microsoft.com/en-us/library/haa3afyz(v=vs.80).aspx[^]
"You should always call the Close method when you have finished using the DataReader object.
If your Command contains output parameters or return values, they will not be available until the DataReader is closed.
Note that while a DataReader is open, the Connection is in use exclusively by that DataReader. You cannot execute any commands for the Connection, including creating another DataReader, until the original DataReader is closed."
So at the top of your else condition, add this:

C#

reader.Close();