Oledb insert command

Question

1.70/5 (3 votes)

See more:

C#

OleDbConnection con = new OleDbConnection(@" provider=Microsoft.ace.Oledb.12.0; data source=\\sisc-erelim\4_Printing\VTDB\DB\VirginiTEADB2.accdb; Persist Security Info=False");

private void button1_Click(object sender, EventArgs e)
{
   try
   {
      OleDbCommand cmd = new OleDbCommand();
      cmd.CommandType = CommandType.Text;
      cmd.CommandText = "INSERT INTO Accountstbl (Username, Password)" + "VALUES ('" + textBox1.Text + "','" + textBox2.Text + "')";
      cmd.Parameters.AddWithValue("@Username", textBox1.Text);
      cmd.Parameters.AddWithValue("@Password", textBox2.Text);
      cmd.Connection = con;
      con.Open();
      cmd.ExecuteNonQuery();
      }
     catch (Exception ex)
     {
         textBox1.Text = ex.ToString();
     }

And I always got this error,

System.Data.OleDb.OleDbException: Syntax error in INSERT INTO statement.
at System.Data.OleDb.OleDbCommand.ExecuteCommandTextErrorHandling(OleDbHResult hr)
at System.Data.OleDb.OleDbCommand.ExecuteCommandTextForSingleResult(tagDBPARAMS dbParams, Object& executeResult)
at System.Data.OleDb.OleDbCommand.ExecuteCommandText(Object& executeResult)
at System.Data.OleDb.OleDbCommand.ExecuteCommand(CommandBehavior behavior, Object& executeResult)
at System.Data.OleDb.OleDbCommand.ExecuteReaderInternal(CommandBehavior behavior, String method)
at System.Data.OleDb.OleDbCommand.ExecuteNonQuery()
at VirginiTEAcorp.Form3.button1_Click(Object sender, EventArgs e) in C:\Documents and Settings\12-014s\My Documents\applications\Database\WindowsFormsApplication1\Form3.cs:line 34
thanks :)

Posted 11-Feb-13 22:08pm

alfred sanz

Updated 11-Feb-13 22:25pm

Jibesh

v3

Add a Solution

Comments

Kiran Susarla 12-Feb-13 4:13am

Where did you define the parameters in the command text?

2 solutions

Solution 2

You have added parameters into your command, but you have injected the values into the SQL. Change your command text into

SQL

INSERT INTO Accountstble (Username, Password) VALUES (?, ?)

Then, remove the @ symbols from the parameter names - they aren't needed as they are used for SQL Server, not Access.

Posted 11-Feb-13 22:31pm

Pete O'Hanlon

Comments

Joezer BH 12-Feb-13 4:56am

5+

Pete O'Hanlon 12-Feb-13 5:04am

Thanks Edo.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jibesh · Accepted Answer · 2013-02-11T22:30:00

Solution 1

Update your insert statement like this

C#

cmd.CommandText = "INSERT INTO Accountstbl (Username, Password)" + " VALUES (@Username,@Password)";

this is because you are already passing the arguments to the query parameter

C#

cmd.Parameters.AddWithValue("@Username", textBox1.Text);
cmd.Parameters.AddWithValue("@Password", textBox2.Text);

Posted 11-Feb-13 22:30pm

Jibesh

Comments

Joezer BH 12-Feb-13 4:57am

5+

Jibesh 12-Feb-13 4:59am

Thank you Edo Tzumer

alfred sanz 12-Feb-13 20:12pm

This is the answer, but there is an error accepting the answer! :( thanks anyway this solve my problem

Jibesh 12-Feb-13 20:13pm

Glad that helped.