Proper format of declaring an update statement SQL

Question

1.00/5 (1 vote)

See more:

Com2.CommandText = "update dbo.UserRecords set Last Login=" & dtpLastLog2.Value.ToString & "where " & txtEmailName.Text & "=Email"

The problem is the program is throwing an exception

System.Data.SqlClient.SqlException: 'Incorrect syntax near 'Login'.'

What I have tried:

I am trying to change time and date once I log in again(Value of dtpLastLog2) and display the time and date in the database (dbo.UserRecord). Where statement I am trying to compare the email saved in my database and the email I type in a textbox name txtEmailName if they have the same value. If they are, the changes will occur.

Posted 7-May-23 22:02pm

Rainy Plant

Updated 7-May-23 22:18pm

Add a Solution

Comments

Richard Deeming 10-May-23 5:17am

Com2.CommandText = "update dbo.UserRecords set [Last Login] = @LastLogin WHERE Email = @Email"
Com2.Parameters.AddWithValue("@LastLogin", dtpLastLog2.Value)
Com2.Parameters.AddWithValue("@Email", txtEmailName.Text)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2023-05-07T22:18:00

Look at the part before that word: set Last Login. What is "Last" in there for? Is the column's actual name two words, or is there a link character missing? If it is the actual name of the column then it needs to be surrounded by square brackets: set [Last Login].

But you have a much more serious problem with the above code, in that you are using string concatenation to build the statement without any checks on the validity of the input values. So your database is vulnerable to SQL injection attack which can compromise, or totally destroy, your system. You need to use parameterised queries for database access in all cases. See bobby-tables.com: A guide to preventing SQL injection[^].