Why a local static...

Question

0.00/5 (No votes)

See more:

int COXEdit::Validate()
{
static CString sFullText;
	int nRet=ValidateInput();

	CString sNewText=GetInputData();
	if ((::IsWindow(m_hWnd)) && (UINT) sNewText.GetLength()>GetLimitText())
	{
		int n=0;
		for (n=0; n<sFullText.GetLength(); n++)
			m_arrInputData.SetAtGrow(n,sFullText.GetAt(n));
		m_arrInputData.SetAtGrow(n,NULL);
	}
	sFullText=COXEdit::GetInputData();
	return nRet;

}

What I have tried:

What is the purpose of that variable. I can not see anything, and the usage of function local statics causes many problems .. Including (but not limited to immediate crash of the containing program is a control is accessed from outside the default Domain)....

Posted 6-Feb-23 2:10am

TheCPUWizard

Updated 6-Feb-23 5:32am

Add a Solution

Comments

KarstenK 7-Feb-23 4:01am

I guess it is a relict from some previous code. Dig into your repo ;-)

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick York · Answer 1 · 2023-02-06T05:32:00

I see no useful purpose for that variable to be static. The variable is assigned but never used for anything so I see no purpose for its existence at all. Also, the way it is calling GetInputData is a bit weird because that syntax is usually used for calling static methods.

If I had to deal with that code I would comment off both the declaration of sFullText and the line where it is assigned and see what happens. Unless there are side effects in the GetInputData function, nothing should happen.

OriginalGriff · Answer 2 · 2023-02-06T02:23:00

static in C++ means different things depending on where it is used: a static variable inside a function is allocated for the lifetime of the application, and even if the function is called many times the value is preserved. For example, if you initialize a static variable to zero, and treh function increments it each time it is called, then it will retain the value from the previous call acting as a "calls counter" for that function.
If it is declared an non-static, the value is not retained.

In your code, the string is preserved within the function so it "grows" each time the function is called.

Why a local static...

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0