How could I change this method so that the return true statement isnt inside of the loop but still works correctly.

Question

0.00/5 (No votes)

See more:

I need this method to work the exact same way however there to be no return statement inside the loop.

What I have tried:

Here is this method.

Java

<pre>public boolean removeAssistant(int identity)
    {
        Iterator<Assistant> it = assistants.iterator();
        while(it.hasNext()){
            Assistant assistant = it.next();
            if(identity == assistant.getIdentity()){
                assistants.remove(assistant); 
                return true;
            }
        }
        return false;
    }

Posted 21-Nov-22 4:34am

Freddie Francis

Updated 21-Nov-22 4:39am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2022-11-21T04:39:00

Solution 1

Java

public boolean removeAssistant(int identity)
    {
        boolean success = false;
        Iterator<Assistant> it = assistants.iterator();
        while(success == false  && it.hasNext()){
            Assistant assistant = it.next();
            if(identity == assistant.getIdentity()){
                assistants.remove(assistant); 
                success = true;
            }
        }
        return success;
    }

Posted 21-Nov-22 4:39am

CPallini

Comments

CPallini 21-Nov-22 11:00am

Why not?

OriginalGriff 21-Nov-22 11:02am

Because the original code only removes the first one it finds - it doesn't touch any others.

Richard Deeming 21-Nov-22 11:02am

Because I need more coffee - I didn't notice the success variable taking the place of a break statement. 😳