Redirection outside controller from another method

Question

0.00/5 (No votes)

See more:

I have several ActionResults where I implemented below condition.

C#

public async Task<ActionResult> Status(int Id)
{
      if (Id <= 0)
      {
          TempData["Errors"] = "Invalid data";

          return RedirectToAction("Error", "Dashboard");
      } ....
 }

I want to move this complete if condition to a separate method and call it where needed. Please advice

What I have tried:

Below is what I tried but redirection does not work

C#

public async Task<ActionResult> Status(int Id)
        {
            UtilityHelpder helper = new UtilityHelper();
            await helper.IdCheck(this, Id);

            ...
        }


public class UtilityHelper
    {
        public async Task IdCheckHelper(Controller controller, int Id)
        {
            if (Id <= 0)
            {
            controller.TempData["Errors"] = "Invalid data";
            controller.HttpContext.Response.Redirect("/Dashboard/Error");
            }
        }
    }

Posted 9-Nov-22 6:05am

Member 10252017

Updated 12-Feb-23 5:30am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

developer_1605 · Answer 1 · 2023-02-12T05:30:00

May be the issue with your code is that you are redirecting to "/Dashboard/Error" using HttpContext.Response.Redirect(). Since you are calling this method from a different class, it does not have access to the URL of your current request, which is why the redirection does not work.

Instead of using HttpContext.Response.Redirect(), you can return a RedirectToActionResult from your IdCheckHelper method.

example:

C#

if (Id <= 0)
      {
          controller.TempData["Errors"] = "Invalid data";
          return new RedirectToActionResult("Error", "Dashboard", null);
      }
      return null;