!! Not getting the answer for finding duplicate string on an array ! !

Question

1.00/5 (2 votes)

See more:

I hope you got my question - !
I expect output -

[Mahendra, Singh, Dhoni, Virat, Singh, Tracktor, Mahendra]
The dupli Strings are -
Mahendra
Singh

What I have tried:

package Functions;
import java.util.*;
import java.util.Arrays;
public class stringString {
public static void main(String[] args) {
String name = "Mahendra Singh Dhoni Virat Singh Tracktor Mahendra";
String[] arr = name.split(" ");
System.out.println(Arrays.toString(arr));
System.out.println("The dupli Strings are - ");
for(int i=0;i<arr.length;i++) {
	for(int j=i+1;j<arr.length;j++) {
		if(arr[i]==arr[j]) {
			System.out.println(arr[j]);
				}
			}
		}
	}
}

Posted 7-Nov-22 22:56pm

Shubham Guha_1007_IMCA1

Updated 7-Nov-22 23:39pm

Add a Solution

Comments

Richard Deeming 8-Nov-22 5:06am

Well, I'm sure all those unnecessary exclamation points in your question title will more than make up for the complete lack of detail in your question. 🤦‍♂️

Click the green "Improve question" link and edit your question. Give it a short but descriptive title. And add a clear and complete description of what you have tried, what the problem is, and where you are stuck. If you're not getting the expected output from your code, explain what output you are getting.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2022-11-07T23:18:00

Solution 1

Java

if(arr[i]==arr[j]) {

The above code compares two references. To compare strings you need to use the equals method:

Java

if(arr[i].equals(arr[j])) {

Posted 7-Nov-22 23:18pm

Richard MacCutchan

CPallini · Accepted Answer · 2022-11-07T23:23:00

Solution 2

Replace

Quote:
if(arr[i]==arr[j]) {

with

Java

if(arr[i].equals(arr[j])) {

That's a quirk of Java, see, for instance, Comparing Strings in Java[^].

Posted 7-Nov-22 23:23pm

CPallini

Updated 7-Nov-22 23:24pm

v2

Mirzakhmet Syzdykov · Accepted Answer · 2022-11-07T23:39:00

This is correct to compare hash codes rather than pointers to String class:

Java

if (arr[i].equals(arr[j])) ...;

Alternatively you can use HashSet<string> in java.util.* due to performance issues, as your algorithm is quadratic, it can be replaced with linear version O(n):

Java

import java.util.HashSet;

...

HashSet<String> strings = new HashSet<>();

for (int i = 0; i < arr.length; ++i) {
  if (strings.contains(arr[i])) { // check if it's already in the hash set
    System.out.println("Duplicate found: " + arr[i]);
  }

  strings.add(arr[i]); // add the string to hash set
}

!! Not getting the answer for finding duplicate string on an array ! !

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us