Help to solve this problem on C language

Question

1.00/5 (1 vote)

See more:

HELP!
Write a program that reads a set of 20 ratings, calculates the maximum and minimum of that set of ratings.

What I have tried:

this is my code (in spanish)

C

#include <stdio.h>
#include <conio.h>

int x,c;
float n=0,baja,alta;

int main (void)
{
	for (c=1;c<=20;c++)
	{
		printf ("%i-. Ingresa calificacion:\n\n",c);
		scanf ("%f", &n);
	}

	if (x==1)
	{
		alta=n;
		baja=n;
	}
	else
	{
		if(n<baja)
		{
			baja=n;
		}
		else
		{
			if (n>alta)
			{
				alta=n;
			}
		}
	}
	
	printf ("La calificacion mas baja es: %.2f \n", baja);		
	printf ("La calificacion mas alta es: %.2f \n", alta);	
		
	getch ();
	return 0;
}

Posted 16-Oct-22 5:20am

Gelo Noob

Updated 16-Oct-22 12:33pm

Dave Kreskowiak

v2

Add a Solution

Comments

Dave Kreskowiak 16-Oct-22 11:57am

And? What's the question?

It would also help if your code was properly indented.

Oh, and ALWAYS use curly braces around your code where "optional". The elimination of curly braces for a single statement is what usually gets noobs in trouble when writing code.

I fixed the formatting of your code and inserted braces where appropriate. It seems to have made when you mistake is quite obvious.

2 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

merano99 · Answer 1 · 2022-10-16T12:33:00

Besides the bug that Richard has already pointed out and the bracket problems that Dave has already partially fixed, there are a few more things that don't work well. I have written the error locations as comments in the source code.

C

int main(void)
{
	// do not declare variables global, x not used
	int c;  //x
	float n = 0, baja, alta;

	for (c = 1; c <= 20; c++)
	{
		printf("%i-. Ingresa calificacion:\n\n", c);
		scanf("%f", &n);
	// }  

	  // The uninitialized local variable "x" was used, change to c
	  // if (x == 1)
	  if (c == 1) {
		 alta = n;
		 baja = n;
	  }
	  else {
	     if (n<baja) {
            baja = n;
	     }
	     // else {
	     if (n>alta) {
            alta = n;
	     }
	  }
	}

And then one more note:

C

// warning: 'getch': The POSIX name for this item is deprecated, use _getch()
_getch();

My suggestion would be to dispense with both conio.h and getch() and instead use getchar() to wait for user input.

Richard MacCutchan · Answer 2 · 2022-10-16T06:19:00

Solution 1

C++

if(n<baja)
{
    baja=n;
}
else
{
    if (n>alta)
    {
        alta=n;
    }
}

In the above code if the first test is true it will not do the second test. So move it out of the else block thus:

C++

if(n<baja)
{
    baja=n;
}
if (n>alta)
{
    alta=n;
}

Posted 16-Oct-22 6:19am

Richard MacCutchan

Help to solve this problem on C language

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Help to solve this problem on C language

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us