Set destinatio of agent in array unity3d

Question

0.00/5 (No votes)

See more:

I have 2 arrays, Deffenders and Attackers.
I iterate through the arrays and set the NavMeshAgent destination of the Deffenders to each Attackers position. That all works great.
The problem is that if i have more Deffenders than attackers then i get an error of index out of bounds, and the extra Deffenders dont move.
How can i solve that?
Bellow is my code.
Thank you.

What I have tried:

<pre>
    void Start() 
    {

        for (int i = 0; i < defenders.Length; i++)
        {
            agents.Add(defenders[i].GetComponent<NavMeshAgent>());
        }


    } 
    
    void FixedUpdate() 
    {
       

        for (int j = 0; j < attackers.Length; j++)
        {
            attackersPos = attackers[j].transform.position;
            defendersPos = defenders[j].transform.position;
            
            distanceBetweenEnemies = Vector3.Distance(attackersPos, defendersPos);
            

            if (distanceBetweenEnemies >= 3f)
            {
                
                foreach (var agent in agents)
                {
                    if(defenders.Length > attackers.Length)
                    {
                        foreach(GameObject defender in defenders)
                        {
                            agent.SetDestination(attackers[j].transform.position - spaceBetweenEnemies);
                        }
                    }
                    agent.SetDestination(attackers[j].transform.position - spaceBetweenEnemies);
                    j++;
                }
                

            }

        }
    }

Posted 31-May-22 21:36pm

simple world

Updated 31-May-22 21:46pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2022-05-31T21:46:00

Solution 1

C#

for (int j = 0; j < attackers.Length; j++)
{
    attackersPos = attackers[j].transform.position;
    defendersPos = defenders[j].transform.position;

You are assuming here that the defenders' array is the same length as that of the attackers. If the defenders' is smaller then you will quite logically get the error you see. You must check the index is valid before you try to use it. Alternatively make sure both arrays contain the same number of items.

[edit]
You also have a problem in this code:

C#

agent.SetDestination(attackers[j].transform.position - spaceBetweenEnemies);
j++;

You are incrementing j, but it is already being incremented by the for statement above, so it could well be set to an invalid number.
[/edit]

Posted 31-May-22 21:46pm

Richard MacCutchan

Updated 31-May-22 21:51pm

v2

Comments

simple world 1-Jun-22 3:50am

I do not understand what you are saying, wether its the attackers array or the defenders array in the for loop i get the same result, index out of bound, and the arrays can not be the same length, one will have more that the other.
Thank you.

Richard MacCutchan 1-Jun-22 3:51am

See my update.

simple world 1-Jun-22 3:54am

Yes i saw your update thank you.
But if i dont increment the j variable then the gameobjects position in the deffenders array only goes to one gamobject of the attackers array. Imagine i have 10 "enemies" in the Deffendes array and 10 "enemies" in the attackers array, if i dont increment the j then all 10 enemies from the deffenders array will go to one enemie from the attackers array.
Hope it makes sence

Richard MacCutchan 1-Jun-22 4:13am

Then you need to rethink what your code it trying to do. As it stands you can easily increment j beyond its limit, hence the error.

simple world 1-Jun-22 4:16am

I want at the begining to have the same number of enemies, the the enemies fight each other and when a enemy from lets say the attackers array dies, then the extra enemies from the deffenders array go to another enemy to fight, and so on.
Do you have any advice?
Thank you for your time

Richard MacCutchan 1-Jun-22 4:43am

Sorry, no. I have never used Unity, so I do not know how attackers and defenders relate to actual program structures.