Click here to Skip to main content
15,885,985 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
So, I tried to make a french quiz but it doesnt work. Whenever I press the button a thousand message boxes pop up. The reason I dont want to delete it is that I dont want people to skip the questions they got wrong.

What I have tried:

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace French_Test
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
        string Q1 = "Je suis";
        string Q2 = "Tu es";
        string Q3 = "Il/elle est";
        string Q4 = "nous sommes";
        string Q5 = "vous etes";
        string Q6 = "Ils/elles sont";
        Random r = new Random();

        private void button1_Click(object sender, EventArgs e)
        {
            

            string[] words = { Q1, Q2, Q3, Q4, Q5, Q6 };
            label1.Text = words[r.Next(0, words.Length)];
           
          
            case1:
            if (label1.Text == Q1)
            {
               if ("I am" == textBox1.Text) 
                  {
                    MessageBox.Show("Correct");
                    
                  }
                else
                {
                    MessageBox.Show("Incorrect");
                    goto case1;
                }
            }


        case2:
            if (label1.Text == Q2)
            {
                if ("You are" == textBox1.Text)
                {
                    MessageBox.Show("Correct");
                }
                else
                {
                    MessageBox.Show("Incorrect");
                    goto case2;
                }
            }

        case3:
            if (label1.Text == Q3)
            {
                if ("He/She is" == textBox1.Text)
                {
                    MessageBox.Show("Correct");
                }
                else
                {
                    MessageBox.Show("Incorrect");
                    goto case3;
                    
                }
            }

        case4:
            if (label1.Text == Q4)
            {
                if ("We are" == textBox1.Text)
                {
                    MessageBox.Show("Correct");
                }
                else
                {
                    MessageBox.Show("Incorrect");
                    goto case4;
                }
            }

        case5:
            if (label1.Text == Q5)
            {
                if ("You are (pl)" == textBox1.Text)
                {
                    MessageBox.Show("Correct");
                }
                else
                {
                    MessageBox.Show("Incorrect");
                    goto case5;
                }
            }

        case6:
            if (label1.Text == Q6)
            {
                if ("They are" == textBox1.Text)
                {
                    MessageBox.Show("Correct");
                }
                else
                {
                    MessageBox.Show("Incorrect");
                    goto case6;
                }
            }
        }

        private void Form1_Load(object sender, EventArgs e)
        {

        }
    }
}
Posted
Updated 19-Sep-21 23:04pm
Comments
Richard MacCutchan 20-Sep-21 5:23am    
Remove all those goto statements, they are the cause of the problem.

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
private int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Quote:
C#
case1:
    if (label1.Text == Q1)
    {
        if ("I am" == textBox1.Text) 
        {
            MessageBox.Show("Correct");
        }
        else
        {
            MessageBox.Show("Incorrect");
            goto case1;
        }
    }
Think about what you've told your code to do here. If the label text matches Q1, and the textbox text is not equal to "I am", you display an "incorrect" message. Then, without changing any of the variables involved, you go back to the "case1" label and check again. Since none of the variables will have changed, you show the "incorrect" message again, and go back to the "case1" label and check again.

If you can't see the problem with that in your head, then use the debugger to step through your code to see what it's doing.
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900