How to combine two streamwriters to make them work?

Question

1.00/5 (1 vote)

See more:

Hello, I'm trying to combine two of my methods into one to save space and improve functionality. Can anyone advise me how to combine these two codes so that they work? The first method is to write the line number at the beginning of the text document, the second method is to write the duration to the text document. I would like each line to have a number to show how much time it is.

EDIT2:
Can someone advise me how to add line numbering to my code?

What I have tried:

C#

public void lineNumber()
        {
            {
                StreamReader sr1 = File.OpenText(path);
                string s = "";
                int counter = 1;
                StringBuilder sb = new StringBuilder();
                while ((s = sr1.ReadLine()) != null)
                {
                    var lineOutput = counter++ + " " + s;
                    sb.Append(lineOutput);
                }
                sr1.Close();
                StreamWriter sw1 = File.AppendText(path);
                sw1.Write(sb);
                sw1.Close();

            }
        }

and

C#

private void writeText(string strPath, TimeSpan tsDuration)
       {
           var list = new List<TimeSpan>();
           string line;

           var streamReader = new StreamReader(strPath);
           while ((line = streamReader.ReadLine()) != null)
           {
               list.Add(TimeSpan.Parse(line));
           }
           list.Add(tsDuration / suma);
           list = list.OrderBy(i => i).ToList();
           streamReader.Close();
           StreamWriter streamWriter = new StreamWriter(strPath, false);
           foreach (var item in list)
           {
               streamWriter.WriteLine(item);
           }
           streamWriter.Close();
       }

EDIT:

C#

private List<TimeSpan> list;
private void writeText(string strPath, TimeSpan tsDuration)
       {
         readFile(strPath, tsDuration);
         writeFile(strPath);
       }
private void readFile(string strPath, TimeSpan tsDuration)
       {
           
           string line;

           var streamReader = new StreamReader(strPath);
           while ((line = streamReader.ReadLine()) != null)
           {
               list.Add(TimeSpan.Parse(line));//here I have error: String was not recognized as a valid timespan.
           }
           list.Add(tsDuration / suma);
           list = list.OrderBy(i => i).ToList();
           streamReader.Close();
        }
private void writeFile(string strPath);
        {
         StreamWriter streamWriter = new StreamWriter(strPath, false);
         foreach (var item in list)
           {
               streamWriter.WriteLine(item);
           }
          streamWriter.Close();
 
         }

EDIT2:
I don't know how to do it at all, I'll be very happy for advice.
Thank you for any advice!

Posted 20-Jun-21 21:48pm

Member 15170612

Updated 21-Jun-21 0:43am

v4

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2021-06-20T22:29:00

Solution 1

My advice: don't (as I have suggested already in your previous question). A method should do just one job. The reading method should read the input file and create a List<t> or other appropriate collection of objects. The business methods should manipulate the data as required. The writing method should just write the final data to the output file.

Posted 20-Jun-21 22:29pm

Richard MacCutchan

Comments

Member 15170612 21-Jun-21 4:44am

So do you think I should just read to the list as a method, then write as a method and then to merge into the necessary method?

Richard MacCutchan 21-Jun-21 5:21am

No, keep them separate. Use the Single Responsibility Principle (part of the SOLID group). Each method or function should be responsible for only one job. It makes the code cleaner, easier to understand, easier to test, and when something needs to change it does not require a large rewrite.

Think about what each method needs to do, and try and use meaningful names.

In your lineNumber method you are reading an input file, adding line numbers to each line and then writing the new strings to an output file. But why would you ever need the line numbers saved in a file? The only time you are likely to need them is in a print out used by a human.

In your writeText method you are reading an input file, extracting some data and again, writing to an output file. And again, why do you need to do that, since the data can be extracted from the original file any time you need to process it?

Member 15170612 21-Jun-21 5:29am

In the writeText method, I do this to sort the values so that they are listed in ascending order.

In lineNumber method, I would like to number it so that it can be better oriented in it when opening the file.

Sorry for names my method and all other functions I am not from an English speaking country.

Richard MacCutchan 21-Jun-21 5:33am

But they are both a waste of time. The only time you need that information is when you are processing it. Saving it in other files serves no real purpose.

Member 15170612 21-Jun-21 5:46am

I'm trying to improve it on the issue.

Richard MacCutchan 21-Jun-21 5:53am

Then try and use the suggestions I have made above. And always, before you start to write code, you need to think carefully about what your application is required to do.

Member 15170612 21-Jun-21 5:12am

I tried to remake it.