Click here to Skip to main content
15,886,026 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
Given a integer n and array of integers of size n , if any of the integer has frequency greater than 1, then output "YES" else "NO".
Example - n = 80
array = [300385365 542329329 207009966 677383701 499030221 979765969 777791551 857948103 339896489 948069158 842663446 999597142 857948103 908407904 698354052 569912220 576017432 499030221 999597142 662758591 498377811 694029224 944959317 833905962 729543123 452128767 591093349 677383701 563034804 958364266 563034804 694029224 339896489 339896489 498377811 833905962 849488735 694029224 17586689 908407904 694029224 662758591 945082107 849488735 842663446 694029224 662758591 702156453 300385365 453230623 729...
]


What I have tried:

I have tried following code but it gives runtime error. I'm not able to find out why I'm getting the runtime error.
C++
int n;
cin>>n;
vector<int>v(n);
bool flag = false;
map<int,int> mp;
for(int  i=0;i<n;i++){
    cin>>v[i];
    mp[v[i]]++;
    if(mp[v[i]] > 1){
        flag = true;
    }
}
if(flag) cout<<"YES\n";
else cout<<"NO\n";

please anyone tell what to do to get rid of this runtime error ??
Posted
Updated 8-Mar-21 8:05am
v2
Comments
Patrice T 7-Mar-21 8:52am    
And the error message is ?
CPallini 7-Mar-21 11:26am    
Your code looks correct to me. In order to get proper help you should provide the input data causing the error message and the details of the error message itself as well.

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Comments
Priyanka Somani 7-Mar-21 6:34am    
Well I tried to debug but still unsuccessful. It happens sometimes we are unable to find a small silly mistake which others find easily and that happening now. I tried to debug but if you tell the main mistake then it will be very helpful.
Priyanka Somani 7-Mar-21 6:45am    
Got the error now :)
OriginalGriff 7-Mar-21 7:07am    
See how the debugger can help you? :D
You need to debug your code step by step. Read some Debug tutorial to start.

tip: divide your code into functions and classes to use sample values to easier reproduce some scenarios.
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900