Click here to Skip to main content
15,881,898 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
Hi!

I'm trying to refresh query from VBA and get the Run-time error 9: Subscript out of range.

What I have tried:

Here's my code:

Private Sub cbRefreshLive()
Dim wb As Workbook:         Set wb = ThisWorkbook
wb.Sheets("TODAY").QueryTables(1).Refresh
'wb.Connections("live").Refresh
End Sub


What could be wrong with it?
Posted
Updated 3-Jan-21 10:09am
Comments
Richard MacCutchan 3-Jan-21 7:56am    
Most likely the subscript on QueryTables is out of range. Use the debugger to step through the code to find out why.

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
private int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

Sorry, but we have no access to your data so no way to tell exactly what is going on - so it's going to be up to you to use the debugger and find out.
 
Share this answer
 
Comments
Zaur Bahramov 3-Jan-21 16:09pm    
Thank you!
I have resolvedit with this code.
Application.ScreenUpdating = False
Sheets("TODAY").ListObjects(1).QueryTable.Refresh BackgroundQuery:=False
Application.ScreenUpdating = True

Am novice, so even if it resolved the problem, am not sure if this is the best practice though.
 
Share this answer
 
Comments
Richard MacCutchan 4-Jan-21 4:01am    
Not really the best practice, especially for a beginner. You have four parts of that statement that could cause a failure, but it would be difficult to tell which. Break your statement into its constituent parts so you can easily see what is happening when things go wrong:
wSheet = Sheets("TODAY")list = Sheet.ListObjects(1)qTable = List.QueryTableqTable.Refresh BackgroundQuery:=False

Now if any part causes a failure you will be able to see exactly where.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900