How can I fix a namespace cannot directly contain a members such as fields or methods

Question

1.00/5 (1 vote)

See more:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerCombat : MonoBehaviour

{

     public Animator animator;
     public Transform attackPoint;
     public float attackRange = 0.5f;
     public LayerMask enemyLayers;

    // Update is called once per frame
    void Update()
    {
        if (Input.GetKeyDown(KeyCode.Space)){

        Attack();
        }
    }

    void Attack()
    {

    animator.SetTrigger("Attack");

    Collider2D[] hitEnemies = Physics2D.OverlapCircleAll(attackPoint.position, attackRange, enemyLayers);

    foreach(Collider2D enemy in hitEnemies)
    {
    Debug.Log("We hit" + enemy.name);
    }
    }
}

void OnDrawGizmosSelected()

{


if (attackPoint == null)
     return;

Gizmos.DrawWireSphere(attackPoint.position, attackRange);

}

What I have tried:

I have tried everywhere to find help so i thought someone here could just give me the answer so i can build on it i am new to unity

Posted 16-Dec-20 1:10am

viewset too good

Updated 16-Dec-20 1:43am

Add a Solution

Comments

Richard MacCutchan 16-Dec-20 7:13am

Well you could start by formatting your code so that all the indentations are correct and matched. Then you could tell us which line the error occurs on.

viewset too good 16-Dec-20 7:16am

Yeah sorry i forgot to add which lines the errors are on its on line with void OnDrawGizmosSelected()

Richard MacCutchan 16-Dec-20 7:14am

I assume the error is at OnDrawGizmosSelected, which is outside the class definition.

viewset too good 16-Dec-20 7:15am

yes it is sorry i forget to say which lines it was on you are correct. I dont know what extra code i would have to add. Im new

Richard MacCutchan 16-Dec-20 7:18am

The message is clear you cannot write a method outside of the class definition. If you are unsure of the correct syntax then study the language guide.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-12-16T01:43:00

The message says what it means: fields, properties and methods all have to be part of a class in C#, so you cannot declare them outside one.

What's happening is that you have a spurious close curly bracket immediately above the definition of

void OnDrawGizmosSelected()

which terminates the class definition. Remove it, or move it to the end of the actual class, and it'll probably work better.

If you check and maintain your indentation correctly, this kind of thing becomes a lot more obvious!

C#

    void Attack()
    {

    animator.SetTrigger("Attack");

    Collider2D[] hitEnemies = Physics2D.OverlapCircleAll(attackPoint.position, attackRange, enemyLayers);

    foreach(Collider2D enemy in hitEnemies)
    {
    Debug.Log("We hit" + enemy.name);
    }
    }
}

void OnDrawGizmosSelected()

{

Indent it, and it's more readable:

C#

   void Attack()
      {
      animator.SetTrigger("Attack");
      Collider2D[] hitEnemies = Physics2D.OverlapCircleAll(attackPoint.position, attackRange, enemyLayers);
      foreach(Collider2D enemy in hitEnemies)
         {
         Debug.Log("We hit" + enemy.name);
         }
      }         // <<< --- This ends the Atack function.
   }            // <<< --- So this ends the class.
void OnDrawGizmosSelected()
   {