My C++ program have correct output along with garbage value

Question

1.00/5 (2 votes)

See more:

C++

#include <iostream>
using namespace std;

void revarray(int a[],int start,int end)
{
    int total=end;
    int tmp;
    while(start<end)
    {
       tmp=a[start];
       a[start]=a[end];
       a[end]=tmp;
       start++;
       end--;
    }
    for(int i=0;i<=total;i++)
    {
        cout<<a[i]<<" ";
    }
}
int main()
{
   int n;
   cout<<"ENter range of a array:";
   cin>>n;
   int a[n],i;
   cout<<"Enter array elmensts:";
   for(i=0;i<n;i++)
   {
       cin>>a[i];
   }
   revarray(a,0,n);
}

What I have tried:

C++

#include <iostream>
using namespace std;

void revarray(int a[],int start,int end)
{
    int total=end;
    int tmp;
    while(start<end)
    {
       tmp=a[start];
       a[start]=a[end];
       a[end]=tmp;
       start++;
       end--;
    }
    for(int i=0;i<=total;i++)
    {
        cout<<a[i]<<" ";
    }
}
int main()
{
   int n;
   cout<<"ENter range of a array:";
   cin>>n;
   int a[n],i;
   cout<<"Enter array elmensts:";
   for(i=0;i<n;i++)
   {
       cin>>a[i];
   }
   revarray(a,0,n);
}

Posted 7-Dec-20 5:23am

MCA DDIT

Updated 7-Dec-20 10:45am

CPallini

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2020-12-07T05:36:00

Solution 1

C++

revarray(a,0,n); // change to n - 1

The last element of an array is at offset n - 1, not n.

Posted 7-Dec-20 5:36am

Richard MacCutchan

Comments

CPallini 7-Dec-20 16:23pm

5.

Dave Kreskowiak · Answer 2 · 2020-12-07T06:55:00

Solution 2

Array elements are numbered 0 through n-1. So if you have an array of 10 elements, they are numbered 0 through 9. You have to keep that in mind when you write your code.

Posted 7-Dec-20 6:55am

Dave Kreskowiak

Comments

CPallini 7-Dec-20 16:24pm

5.

CPallini · Answer 3 · 2020-12-07T10:45:00

Probably you are doing it as an exercise on C-like arrays.
Anyway I make you aware that C++ provides containers and iterators

C++

#include <iostream>
#include <vector>
#include <iterator>
using namespace std;

int main()
{
  int n;
  cout << "please enter the number of the array elements\n";
  cin >> n;
  vector <int> v(n,0);
  cout << "now, please, enter the array elements\n";
  for ( auto & x : v)
    cin >> x;
  for ( auto it = rbegin(v); it != rend(v); ++it)
    cout << (*it) << " ";
  cout << endl;
}