Vba link to SQL and error operation is not allowed when the object is closed

Question

0.00/5 (No votes)

See more:

I have a vba to read record from SQL server.
and major code as below

VB

  Set Conn = New ADODB.Connection
  Set rs = New ADODB.Recordset
  Conn.CursorLocation = adUseServer
  Conn.Open ConStr
  Set cmd = New ADODB.Command
  cmd.CommandText = StoredProcedureName
  cmd.CommandType = adCmdStoredProc
  cmd.ActiveConnection = Conn
  With rs
    Set .ActiveConnection = Conn
    .LockType = adLockOptimistic
    .CursorLocation = adUseServer
    .CursorType = adOpenForwardOnly
    .Open "SET NOCOUNT ON"
  End With

cmd.Parameters("@regisno").Value = "ABC"
cmd.Parameters("@finid").Value = "AF123"
cmd.Parameters("@Month").Value = "2020-09-01"
rs.Open cmd, , , , adCmdStoredProc
If rs.EOF Then
Else
End if

and error message as below
"Operation is not allowed when the object is closed"
program are stop at if rs.eof then

What I have tried:

I'd tried various of @finid some are working fine but some are fail to get record.
even though my SQL program also add in "SET NOCOUNT ON" at initial but result still same.

Your kind advice are many appreciated.
yungu

Posted 17-Sep-20 23:45pm

Member 7945374

Updated 17-Sep-20 23:55pm

Richard Deeming

v2

Add a Solution

Comments

Sandeep Mewara 18-Sep-20 6:03am

Sometimes, Warnings may confuse in the result. Try: SET ANSI_WARNINGS OFF

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2020-09-17T23:55:00

You're calling Open on the Recordset twice, which probably isn't helping.

You should also make sure you're not sharing the connection, command, or recordset variables between multiple methods.

Try something like this:

VB

Set Conn = New ADODB.Connection
Conn.CursorLocation = adUseServer
Conn.Open ConStr

Set cmd = New ADODB.Command
cmd.CommandText = StoredProcedureName
cmd.CommandType = adCmdStoredProc
cmd.ActiveConnection = Conn

cmd.Parameters("@regisno").Value = "ABC"
cmd.Parameters("@finid").Value = "AF123"
cmd.Parameters("@Month").Value = "2020-09-01"

Set rs = New ADODB.Recordset
With rs
    .LockType = adLockOptimistic
    .CursorLocation = adUseServer
    .CursorType = adOpenForwardOnly
End With

rs.Open cmd, , , , adCmdStoredProc

How To Open ADO Connection and Recordset Objects[^]